From: Julien Lepiller <julien@lepiller.eu>
To: Frank Pursel <frank.pursel@gmail.com>, 54021@debbugs.gnu.org
Subject: [bug#54021] [PATCH] package for rhino
Date: Mon, 28 Feb 2022 21:45:16 +0100 [thread overview]
Message-ID: <9FFAD8D6-4C04-4FF9-982A-C0F5B6345F71@lepiller.eu> (raw)
In-Reply-To: <87pmn6eq80.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 8203 bytes --]
Thanks!
I guess my only question remaining is why package this version instead of the latest, 1.7.15?
Also the commit message should be:
gnu: Add rhino.
* gnu/packages/javascript.scm (rhino): New variable
You didn't change the synopsis to spell JavaScript properly. Other than that, it's fine with me. We can take care of that, no need to resend a patch, unless Maxime has other comments :)
On February 28, 2022 8:38:39 PM GMT+01:00, Frank Pursel <frank.pursel@gmail.com> wrote:
>Julien,
>
>A single patch, to rule them all, as requested. :) This patch should add
>the rhino package to the existing javascript.scm file. I think all the
>issues have been addressed. Thank you for your patience.
>
>Regards,
>Frank
>
>From a422095cf0ac8778936661952d375abd35293253 Mon Sep 17 00:00:00 2001
>Message-Id: <a422095cf0ac8778936661952d375abd35293253.1646075744.git.frank.pursel@gmail.com>
>From: Frank Pursel <frank.pursel@gmail.com>
>Date: Tue, 15 Feb 2022 14:07:28 -0800
>Subject: [PATCH] Adding rhino javascript guix package.
>
> * guix/gnu/package/javascript.scm (rhino): Added package.
>---
> gnu/packages/javascript.scm | 103 +++++++++++++++++++++++++++++++++++-
> 1 file changed, 101 insertions(+), 2 deletions(-)
>
>diff --git a/gnu/packages/javascript.scm b/gnu/packages/javascript.scm
>index 779ffcb7b8..68d338de8d 100644
>--- a/gnu/packages/javascript.scm
>+++ b/gnu/packages/javascript.scm
>@@ -6,6 +6,7 @@
> ;;; Copyright © 2018 Nicolas Goaziou <mail@nicolasgoaziou.fr>
> ;;; Copyright © 2021 Pierre Neidhardt <mail@ambrevar.xyz>
> ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
>+;;; Copyright © 2022 Frank Pursel <frank.pursel@gmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
>@@ -26,7 +27,9 @@ (define-module (gnu packages javascript)
> #:use-module ((guix licenses) #:prefix license:)
> #:use-module (gnu packages)
> #:use-module (gnu packages base)
>+ #:use-module (gnu packages bash)
> #:use-module (gnu packages compression)
>+ #:use-module (gnu packages java)
> #:use-module (gnu packages node)
> #:use-module (gnu packages readline)
> #:use-module (gnu packages uglifyjs)
>@@ -34,10 +37,11 @@ (define-module (gnu packages javascript)
> #:use-module (guix packages)
> #:use-module (guix download)
> #:use-module (guix git-download)
>- #:use-module (guix build-system gnu)
>+ #:use-module (guix build-system ant)
> #:use-module (guix build-system cmake)
>- #:use-module (guix build-system trivial)
>+ #:use-module (guix build-system gnu)
> #:use-module (guix build-system minify)
>+ #:use-module (guix build-system trivial)
> #:use-module (guix utils))
>
> (define-public cjson
>@@ -791,3 +795,98 @@ (define-public duktape
> your build, and use the Duktape API to call ECMAScript functions from C code
> and vice versa.")
> (license license:expat)))
>+
>+(define-public rhino
>+ (package
>+ (name "rhino")
>+ (version "1.7.7.2")
>+ (source (origin
>+ (method git-fetch)
>+ (uri (git-reference
>+ (url "https://github.com/mozilla/rhino.git")
>+ (commit "935942527ff434b205e797df4185518e5369466e")))
>+ (file-name (git-file-name name version))
>+ (sha256
>+ (base32
>+ "09i4yr98hs6855fs7fhgmrpiwpr90lhxdv2bvfj97nn4rv1d7wl8"))
>+ (modules '((guix build utils)))
>+ (snippet '(begin
>+ ;; Remove benchmark testing
>+ (delete-file-recursively "testsrc/benchmarks")
>+ (delete-file-recursively
>+ "testsrc/org/mozilla/javascript/benchmarks")
>+ ;; Identify bundled jars
>+ (format #t "~%~a~%" "Sourced jars")
>+ (for-each (lambda (f)
>+ (format #t "~/Deleting: ~a~%" f)
>+ (delete-file f))
>+ (find-files "." "\\.jar$"))))))
>+ (build-system ant-build-system)
>+ (inputs (list bash-minimal))
>+ (native-inputs (list java-junit java-hamcrest-core java-snakeyaml))
>+ (arguments
>+ `(#:phases
>+ (modify-phases
>+ %standard-phases
>+ (replace 'check
>+ (lambda* (#:key tests? inputs native-inputs
>+ #:allow-other-keys)
>+ (when tests?
>+ (setenv "ANT_OPTS" "-Doffline=true")
>+ (let ((junit-lib
>+ (assoc-ref inputs "java-junit"))
>+ (hamcrest-lib
>+ (assoc-ref inputs "java-hamcrest-core"))
>+ (snakeyaml-lib
>+ (assoc-ref inputs "java-snakeyaml")))
>+ (with-directory-excursion "testsrc"
>+ (substitute* "build.xml"
>+ (("<pathelement location=\"\\$\\{xbean.jar\\}\" */>" all)
>+ (string-append "<!-- " all " -->"))
>+ (("<pathelement location=\"\\$\\{jsr173.jar\\}\" */>" all)
>+ (string-append "<!-- " all " -->"))
>+ (("<pathelement path=\"\\$\\{coverage.classes.dir\\}\" */>"
>+ all)
>+ (string-append "<!-- " all " -->"))
>+ (("<pathelement path=\"lib/emma.jar\"/>" all)
>+ (string-append "<!-- " all " -->"))
>+ (("<pathelement path=\"lib/junit.jar\" ?/>")
>+ (string-append
>+ "<fileset dir=\"" junit-lib "\" includes=\"**/*.jar\"/>"))
>+ (("<pathelement path=\"lib/hamcrest.jar\" ?/>")
>+ (string-append "<fileset dir=\"" hamcrest-lib
>+ "\" includes=\"**/*.jar\"/>"))
>+ (("<pathelement path=\"lib/snakeyaml.jar\" ?/>")
>+ (string-append "<fileset dir=\"" snakeyaml-lib
>+ "\" includes=\"**/*.jar\"/>"))
>+ ;; Disabling instrumentation.
>+ (("(<target name=\"junit\" depends=\"junit-compile),.*"
>+ all pre)
>+ (string-append pre "\">"))))
>+ (invoke "ant" "junit")))))
>+ (replace 'install
>+ (lambda* (#:key inputs outputs #:allow-other-keys)
>+ (let* ((out (assoc-ref outputs "out"))
>+ (pkg+ver (string-append ,name ,version))
>+ (bin (string-append out "/bin"))
>+ (rhino (string-append bin "/rhino"))
>+ (man (string-append out "/share/man/man1")))
>+ (mkdir-p bin)
>+ (install-file "man/rhino.1" man)
>+ (install-file (string-append "build/" pkg+ver
>+ "/js.jar")
>+ (string-append out "/share/java"))
>+ (with-output-to-file rhino
>+ (lambda _
>+ (format #t "#!~a~%~a -jar ~a $@~%"
>+ (search-input-file inputs "/bin/bash")
>+ (search-input-file inputs "/bin/java")
>+ (string-append out "/share/java/js.jar"))))
>+ (chmod rhino #o755)))))))
>+ (home-page "https://mozilla.github.io/rhino")
>+ (synopsis "Javascript implemented in Java")
>+ (description
>+ "Rhino implements ECMAScript, also known as JavaScript, in Java as
>+specified in the fifth edition of ECMA-262.")
>+ (license license:mpl2.0)))
>+
>--
>2.34.0
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 8798 bytes --]
next prev parent reply other threads:[~2022-02-28 20:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 1:58 [bug#54021] [PATCH] Add rhino javascript package Frank Pursel
2022-02-16 17:00 ` Maxime Devos
2022-02-16 17:02 ` Maxime Devos
2022-02-16 17:08 ` Julien Lepiller
2022-02-16 17:08 ` Maxime Devos
2022-02-16 17:09 ` Maxime Devos
2022-02-16 17:21 ` Maxime Devos
2022-02-16 18:36 ` Frank Pursel
2022-02-16 18:43 ` Maxime Devos
2022-02-17 5:22 ` [bug#54021] [PATCH] Adding rhino package, revised patch Frank Pursel
2022-02-21 16:28 ` Maxime Devos
2022-02-18 20:42 ` [bug#54021] [PATCH] if, at first, you don't succeed Frank Pursel
2022-02-21 13:19 ` Efraim Flashner
2022-02-21 15:54 ` [bug#54021] [PATCH] Better rhino Frank Pursel
2022-02-21 18:45 ` [bug#54021] [PATCH] Removing all bundled jars prior to build Frank Pursel
2022-02-26 21:07 ` Julien Lepiller
2022-02-28 19:38 ` [bug#54021] [PATCH] package for rhino Frank Pursel
2022-02-28 20:45 ` Julien Lepiller [this message]
2022-02-28 21:45 ` [bug#54021] [PATCH] question -> answers Frank Pursel
2022-03-01 21:26 ` bug#54021: [PATCH] Add rhino javascript package Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9FFAD8D6-4C04-4FF9-982A-C0F5B6345F71@lepiller.eu \
--to=julien@lepiller.eu \
--cc=54021@debbugs.gnu.org \
--cc=frank.pursel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.