From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Sarah Morgensen <iskarian@mgsn.dev>
Cc: 48111-done@debbugs.gnu.org
Subject: bug#48111: tilde in Go package names (eg. sourcehut hosted packages)
Date: Mon, 05 Jul 2021 09:57:14 +0200 [thread overview]
Message-ID: <99ccdaecd57d5766ee5920e811a934b9b2a58394.camel@student.tugraz.at> (raw)
In-Reply-To: <86czrxae1w.fsf@mgsn.dev>
Hello,
Am Sonntag, den 04.07.2021, 15:51 -0700 schrieb Sarah Morgensen:
> It might be slightly uglier, but I think it's better to keep a
> consistent policy of "replace any invalid characters with a hyphen",
> as it is less likely to generate collisions and it provides a hint to
> the reader that there *is* a character there.
Fair enough, that's a reasonable take.
> I have attached a patch to do so below, verified that a recursive
> import of the package mentioned above builds without modification
> (well, I had to update a dependency...) and verified that there are
> not currently any go packages using a tilde in their name with:
>
> $ egrep -r '"go-[^"]*~[^"]*"' gnu/packages
I couldn't verify this as the importer delivered 410s, but the patch
LGTM, so I pushed it.
Thanks,
Leo
prev parent reply other threads:[~2021-07-05 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 17:54 bug#48111: tilde in Go package names (eg. sourcehut hosted packages) raingloom
2021-04-30 9:53 ` Leo Prikler
2021-05-03 2:16 ` raingloom
2021-07-04 22:51 ` Sarah Morgensen via Bug reports for GNU Guix
2021-07-05 7:57 ` Leo Prikler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99ccdaecd57d5766ee5920e811a934b9b2a58394.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=48111-done@debbugs.gnu.org \
--cc=iskarian@mgsn.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.