all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: phodina <phodina@protonmail.com>, 49942@debbugs.gnu.org
Subject: [bug#49942] [PATCH] gnu: Add shell-color-scripts
Date: Sat, 18 Sep 2021 15:09:07 +0200	[thread overview]
Message-ID: <975a441334b97bb04d18e2fc39f98d1cfffa5ccc.camel@telenet.be> (raw)
In-Reply-To: <j8v3TScCyT2ee_PoedHUN88Wwq32xEEoM11Asud9wWugE58sgw1tSxrWz7rtR9O-rJjZyZDk5xP7LkTJFLkwn8ZQgj9rFI75SGEsb8D3cw4=@protonmail.com>

[-- Attachment #1: Type: text/plain, Size: 1933 bytes --]

Hi,

> +(define-public shell-color-scripts
> + (package
> +  (name "colorscript")
> +  (version "3dbdfac24bb629238fdc3e1c8909e2c8577f8735") ; no tags
> +  (source (origin
> +            (method git-fetch)
> +            (uri (git-reference
> +                   (url "https://gitlab.com/dwt1/shell-color-scripts")
> +                   (commit version)))
> +            (file-name (git-file-name name version))
> +            (sha256
> +             (base32
> +              "0lkiz6fkrqryr1vh0lh067q7hp8ba8887pkk8caipqphjswp2z16"))))
> +  (build-system copy-build-system)
> +  (arguments
> +    `(#:install-plan '(("colorscript.sh" "bin/colorscript.sh")
> +                       ("colorscripts" "colorscripts"))
> +      #:phases
> +      (modify-phases %standard-phases
> +        (add-after 'unpack 'fix-colorscipts-location
> +          (lambda* (#:key outputs #:allow-other-keys)
> +            (substitute* "colorscript.sh"
> +              (("/opt/shell-color-scripts/colorscripts")
> +               (string-append (assoc-ref outputs "out") "/colorscripts"))))))))
> +  (inputs `(("ncurses" ,ncurses)))

Missing: 'awk', 'sed' and 'coreugils'.
The colorscript.sh needs some ‘absolutification’, e.g. using 'substitute*',
to refer to awk, sed, tr, wc ... by their absolute path instead of using
whatever is in the profile.

Some script in ‘colorscripts’ may need changes as well

> +  (synopsis "Collection of terminal color scripts")
> +  (description "Collection of terminal color scripts")
> +  (home-page "https://gitlab.com/dwt1/shell-color-scripts")
> +  (license license:expat))) ; MIT

"; MIT" isn't necessary, as license:expat is unambigious,
whereas MIT is sometimes used for the X11 license and can theoretically
refer to any license ever used by MIT.  (Though in practice ‘the MIT license’
either refers to the X11 or the expat license.)

Greetings,
Maxime

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2021-09-18 13:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-08 11:50 [bug#49942] [PATCH] gnu: Add shell-color-scripts phodina via Guix-patches via
2021-09-18  8:09 ` [bug#49942] Patch status phodina via Guix-patches via
2021-09-18 13:09 ` Maxime Devos [this message]
2021-09-18 14:10 ` [bug#49942] [PATCH v2] gnu: Add shell-color-scripts phodina via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=975a441334b97bb04d18e2fc39f98d1cfffa5ccc.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=49942@debbugs.gnu.org \
    --cc=phodina@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.