From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Dariqq <dariqq@posteo.net>, Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 70282@debbugs.gnu.org, Vivien Kraus <vivien@planete-kraus.eu>
Subject: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service.
Date: Fri, 10 May 2024 18:04:21 +0200 [thread overview]
Message-ID: <9717bead5b1eb65af01143131e7e46fe835ab682.camel@gmail.com> (raw)
In-Reply-To: <532cafdd-afc3-4c2b-bd4a-a2be3318747c@posteo.net>
Am Freitag, dem 10.05.2024 um 14:59 +0000 schrieb Dariqq:
> Hi Liliana and Maxim,
>
> On 09.05.24 00:11, Liliana Marie Prikler wrote:
> > Hi Dariqq,
> >
> > Am Mittwoch, dem 08.05.2024 um 21:18 +0000 schrieb Dariqq:
> > > [...]
> > >
> > > On 08.05.24 21:51, Maxim Cournoyer wrote:
> > >
> > > > [...]
> > > > Perhaps a simple patch would convey the change better and be
> > > > easier
> > > > to
> > > > maintain in the future / be readily available for other
> > > > distributions to
> > > > use.
> > >
> > > The simple patch that would do this is basically the patch from
> > > nixos
> > > in v1 of this which adds a shebang line for gjs to the service
> > > invocation files (rather than the dbus service invoking $gjs
> > > $service). The problem then is that wrap-program changes the
> > > filename
> > > to * .real which makes gjs unhappy.
> > >
> > > [...]
> > > Maybe another comment, similiar to the one Liliana suggested
> > > earlier
> > > in this thread, could be added at the beginning to inform about
> > > changing to wrap script + patch instead once that is a viable
> > > option?
> > The pattern we typically use is to add an autotools-style
> > "variable",
> > e.g. @GNOME_SHELL_GST_PLUGIN_SYSTEM_PATH@ through a patch, then use
> > substitute* to fill it in. I don't think it's a requirement, but
> > since
> > Maxim suggested, it'd definitely be nice to have.
> >
>
> Tried this today and as the js service files are created from a
> common template using mesons 'configure_file' method this sets all
> autotools-style variables unknown to meson to the empty string.
> Afterwardes the susbtitute* at the wrapping phase is unable to
> replace anything ofc.
>
> So I think I would need to either change the naming-scheme of the
> placeholders or substitute them into the template file before the
> files get configured by meson.
Or you add an option to meson_options.txt to fill it in, so that you
can provide the right value via #:configure-flags
Cheers
next prev parent reply other threads:[~2024-05-10 16:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 15:39 [bug#70282] [PATCH 0/2] Fix gnome-shell screenrecorder Dariqq
2024-04-08 15:53 ` [bug#70282] [PATCH 1/2] gnu: gnome-shell: Wrap d-bus services Dariqq
2024-04-08 16:54 ` Liliana Marie Prikler
2024-04-09 15:35 ` Dariqq
2024-04-09 17:04 ` Liliana Marie Prikler
2024-04-10 8:07 ` Dariqq
2024-04-10 18:20 ` Liliana Marie Prikler
2024-04-11 9:04 ` Dariqq
2024-04-08 15:53 ` [bug#70282] [PATCH 2/2] gnu: gnome-essential-extras: Propagate pipewire Dariqq
2024-04-08 16:49 ` Liliana Marie Prikler
2024-04-09 14:05 ` Dariqq
2024-04-12 17:26 ` [bug#70282] [PATCH v2] gnu: gnome-shell: Wrap screencast service Dariqq
2024-04-19 18:51 ` Liliana Marie Prikler
2024-04-20 10:11 ` Dariqq
2024-04-20 10:46 ` Liliana Marie Prikler
2024-04-21 12:37 ` Dariqq
2024-04-21 12:43 ` Liliana Marie Prikler
2024-05-08 12:57 ` [bug#70282] [PATCH v3] " Dariqq
2024-04-21 17:02 ` Dariqq
2024-05-08 17:24 ` Liliana Marie Prikler
2024-05-08 18:33 ` [bug#70282] [PATCH v4] " Dariqq
2024-05-08 19:51 ` Maxim Cournoyer
2024-05-08 21:18 ` Dariqq
2024-05-08 22:11 ` Liliana Marie Prikler
2024-05-09 8:27 ` Dariqq
2024-05-10 14:59 ` Dariqq
2024-05-10 16:04 ` Liliana Marie Prikler [this message]
2024-05-11 8:03 ` Dariqq
2024-05-09 15:30 ` Maxim Cournoyer
2024-05-14 5:34 ` bug#70282: " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9717bead5b1eb65af01143131e7e46fe835ab682.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=70282@debbugs.gnu.org \
--cc=dariqq@posteo.net \
--cc=maxim.cournoyer@gmail.com \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.