From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Bruno Victal <mirai@makinata.eu>, 59866@debbugs.gnu.org
Subject: [bug#59866] [PATCH v6 2/3] services: mpd: Refactor MPD service.
Date: Thu, 02 Feb 2023 22:08:02 +0100 [thread overview]
Message-ID: <88e71adf846525fbc1a964b24fb45e3e4b5c9208.camel@gmail.com> (raw)
In-Reply-To: <fe3fc24ea98bf66c95d0c589064a5c2edd7218bd.1675367583.git.mirai@makinata.eu>
Not a complete review yet, just some quick pointers.
Am Donnerstag, dem 02.02.2023 um 20:07 +0000 schrieb Bruno Victal:
> Refactor mpd-service-type to support additional mpd.conf directives
> and move activation-service-extension into service constructor.
>
> * gnu/services/audio.scm
> (mpd-plugin, mpd-partition): New record.
No need to break the line before the paren here.
> (mpd-serialize-boolean, mpd-serialize-field): Integrate serializers
> into a single procedure for alist interop.
That's not a good docstring here. I think
(mpd-serialize-boolean): Delete variable. Move logic into...
(mpd-serialize-field): ... this.
explains what's going on better.
> [...]
> #:use-module (srfi srfi-1)
> + #:use-module (srfi srfi-8)
> #:use-module (srfi srfi-26)
We generally prefer SRFI 71.
Cheers
next prev parent reply other threads:[~2023-02-02 21:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 23:22 [bug#59866] [PATCH 0/2] services: mpd: Refactor MPD service mirai
2022-12-06 23:25 ` [bug#59866] [PATCH 1/2] services: mpd: use 'define-configuration' mirai
2022-12-06 23:25 ` [bug#59866] [PATCH 2/2] services: mpd: Refactor MPD service mirai
2022-12-07 8:59 ` [bug#59866] [PATCH 0/2] " ( via Guix-patches via
2022-12-07 13:42 ` mirai
2022-12-07 13:43 ` ( via Guix-patches via
2022-12-07 18:27 ` Liliana Marie Prikler
2022-12-08 13:11 ` mirai
2022-12-08 13:35 ` [bug#54986] " Liliana Marie Prikler
2022-12-09 13:44 ` [bug#59866] " mirai
2022-12-09 19:22 ` Liliana Marie Prikler
2022-12-11 12:05 ` mirai
2022-12-08 0:59 ` [bug#59866] [PATCH v2] " mirai
2022-12-16 14:15 ` [bug#59866] [PATCH v3] " mirai
2022-12-21 14:15 ` [bug#59866] [PATCH v4 1/2] services: mpd: use 'define-configuration' mirai
2022-12-21 14:15 ` [bug#59866] [PATCH v4 2/2] services: mpd: Refactor MPD service mirai
2022-12-24 13:51 ` [bug#59866] [PATCH v5 1/2] services: mpd: rewrite using 'define-configuration' mirai
2022-12-24 13:51 ` [bug#59866] [PATCH v5 2/2] services: mpd: Refactor MPD service mirai
2022-12-24 14:11 ` [bug#59866] [PATCH v5.1] " mirai
2022-12-24 17:20 ` Liliana Marie Prikler
2022-12-24 19:17 ` mirai
2022-12-24 18:53 ` [bug#59866] [PATCH v5.2] " mirai
2023-01-03 14:43 ` [bug#59866] Pulseaudio woes mirai
2023-01-03 19:38 ` Liliana Marie Prikler
2023-02-02 20:07 ` [bug#59866] [PATCH v6 1/3] services: mpd: Rewrite using 'define-configuration' Bruno Victal
2023-02-02 20:07 ` [bug#59866] [PATCH v6 2/3] services: mpd: Refactor MPD service Bruno Victal
2023-02-02 21:08 ` Liliana Marie Prikler [this message]
2023-02-05 6:11 ` bug#59866: " Liliana Marie Prikler
2023-02-02 20:07 ` [bug#59866] [PATCH v6 3/3] services: mpd: Do not hardcode environment variables Bruno Victal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88e71adf846525fbc1a964b24fb45e3e4b5c9208.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=59866@debbugs.gnu.org \
--cc=mirai@makinata.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.