From: Marius Bakke <mbakke@fastmail.com>
To: manolis837@gmail.com, 26625@debbugs.gnu.org
Subject: bug#26625: [PATCH] gnu : Add unshield.
Date: Mon, 24 Apr 2017 16:52:48 +0200 [thread overview]
Message-ID: <87zif5zwlb.fsf@fastmail.com> (raw)
In-Reply-To: <20170423172345.9116-1-manolis837@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2205 bytes --]
manolis837@gmail.com writes:
> * gnu/packages/compression.scm (unshield): New variable.
[...]
> @@ -40,6 +41,7 @@
> #:use-module (guix build-system gnu)
> #:use-module (guix build-system perl)
> #:use-module (guix build-system python)
> + #:use-module (guix build-system cmake)
> #:use-module (gnu packages)
> #:use-module (gnu packages assembly)
> #:use-module (gnu packages autotools)
> @@ -50,6 +52,7 @@
> #:use-module (gnu packages pkg-config)
> #:use-module (gnu packages python)
> #:use-module (gnu packages valgrind)
> + #:use-module (gnu packages tls)
Please try to keep module imports, inputs, etc alphabetically sorted,
when they are so from before.
> +(define-public unshield
> + (package
> + (name "unshield")
> + (version "1.4.2")
> + (source
> + (origin (method url-fetch)
> + (uri (string-append "http://github.com/twogood/unshield/archive/"
> + version ".tar.gz"))
> + (sha256
> + (base32
> + "0x7ps644yp5dka2zhb8w0ifqmw3d255jafpzfwv8xbcpgq6fmm2x"))))
> + (build-system cmake-build-system)
> + (inputs
> + `(("zlib" ,zlib)
> + ("openssl" ,openssl)))
> + (arguments
> + `(#:tests? #f)) ; no test target
There is a test script shipped with the source, can you try replacing
the "check" phase with code that executes "./run_tests"?
> + (home-page "https://github.com/twogood/unshield")
> + (synopsis "Tool to extract CAB files.")
> + (description "Extracts CAB files from InstallShield installers")
So synopses should not end with punctuations, but descriptions do. `guix
lint` should warn about this. It would be good to have a little more
information here as well.
Maybe something like this (minimal variant):
(synopsis "Extract CAB files from InstallShield installers")
(description
"@command{unshield} is a tool and library for extracting @file{.cab}
archives from InstallShield installers.")
If this software works with the "normal" .cab files commonly found in MS
Windows systems, it would be good to encapsulate that information too.
Otherwise LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-04-24 14:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 17:23 bug#26625: [PATCH] gnu : Add unshield manolis837
2017-04-24 14:52 ` Marius Bakke [this message]
2017-05-02 10:57 ` manolis837
2017-05-02 10:57 ` manolis837
2017-06-04 8:06 ` Manolis Ragkousis
2017-06-04 12:03 ` Marius Bakke
2017-06-04 15:11 ` Manolis Ragkousis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zif5zwlb.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=26625@debbugs.gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.