From: iyzsong@member.fsf.org (宋文武)
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] substitute: Close the download port after substitution finished.
Date: Mon, 18 Sep 2017 19:11:52 +0800 [thread overview]
Message-ID: <87zi9sz2fb.fsf@member.fsf.org> (raw)
In-Reply-To: <87377lf5ke.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 17 Sep 2017 22:12:01 +0200")
ludo@gnu.org (Ludovic Courtès) writes:
> Hi 宋文武,
>
> 宋文武 <iyzsong@member.fsf.org> skribis:
>
>> * guix/scripts/substitute.scm (progress-substitution): Call 'close-port'
>> after 'restore-file'.
>
> Good catch, please push!
>
> How did you notice?
I meet it when test my progress reporter patch at
<https://lists.gnu.org/archive/html/guix-devel/2017-09/msg00190.html>,
which will write the last report to console after close
'progress-report-port'.
Pushed, thanks for the review!
prev parent reply other threads:[~2017-09-18 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-16 7:31 [PATCH] substitute: Close the download port after substitution finished 宋文武
2017-09-17 20:12 ` Ludovic Courtès
2017-09-18 11:11 ` 宋文武 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi9sz2fb.fsf@member.fsf.org \
--to=iyzsong@member.fsf.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.