From: ludo@gnu.org (Ludovic Courtès)
To: Christopher Baines <mail@cbaines.net>
Cc: 29741@debbugs.gnu.org
Subject: [bug#29741] [PATCH 2/2] gnu: services: web: Add service for apache-httpd.
Date: Mon, 18 Dec 2017 11:10:02 +0100 [thread overview]
Message-ID: <87zi6gtkhx.fsf@gnu.org> (raw)
In-Reply-To: <20171216201700.23564-2-mail@cbaines.net> (Christopher Baines's message of "Sat, 16 Dec 2017 20:17:00 +0000")
Hello,
Christopher Baines <mail@cbaines.net> skribis:
> * gnu/services/web.scm (<apache-httpd-load-module>,
> <apache-httpd-config-file>, <apache-httpd-virtualhost>
> <apache-httpd-configuration>): New record types.
> (%default-apache-httpd-modules, %apache-httpd-accounts,
> apache-httpd-service-type): New variables.
> (apache-httpd-shepherd-services, apache-httpd-activation,
> apache-httpd-process-extensions): New procedures.
> * gnu/tests/web.scm (run-apache-httpd-test): New procedure.
> (%apache-httpd-os, %tests-apache-httpd): New variables.
Nice! Documentation will be welcome. :-)
> + #:export (<apache-httpd-configuration>
> + apache-httpd-configuration
> + apache-httpd-configuration?
> + apache-httpd-configuration-package
> + apache-httpd-configuration-pid-file
> + apache-httpd-configuration-config
In this context I think ‘httpd-’ would be good enough as a prefix.
> +(define %default-apache-httpd-modules
> + (map (match-lambda
> + ((name file)
> + (apache-httpd-load-module
> + (name name)
> + (file file))))
> + '(("authn_file_module" "modules/mod_authn_file.so")
> + ("authn_core_module" "modules/mod_authn_core.so")
> + ("authz_host_module" "modules/mod_authz_host.so")
I think having this list here is the right approach. However could you
write where it comes from? I guess it’s equal to the current default in
httpd, right?
How often do you expect this to be updated?
> +(define-record-type* <apache-httpd-config-file>
> + apache-httpd-config-file make-apache-httpd-config-file
> + apache-httpd-config-file?
> + (load-modules apache-httpd-config-file-load-modules
> + (default %default-apache-httpd-modules))
Or “loaded-modules” or just “modules”?
> +(define* (run-apache-httpd-test #:optional (http-port 8080))
> + "Run tests in %APACHE-HTTPD-OS, which has apache-httpd running and listening on
> +HTTP-PORT."
I wonder if we could abstract ‘run-nginx-test’ just enough so it can be
used for both. It’d need to take a service name, log file, and PID file
as arguments.
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2017-12-18 10:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <handler.29741.B.15134551667792.ack@debbugs.gnu.org>
2017-12-16 20:16 ` [bug#29741] [PATCH 1/2] gnu: tests: web: Generalise the test data for the nginx test Christopher Baines
2017-12-16 20:17 ` [bug#29741] [PATCH 2/2] gnu: services: web: Add service for apache-httpd Christopher Baines
2017-12-18 10:10 ` Ludovic Courtès [this message]
2017-12-19 8:03 ` Christopher Baines
2017-12-24 18:01 ` [bug#29741] [PATCH 1/2] gnu: tests: web: Generalise the nginx test Christopher Baines
2017-12-24 18:01 ` [bug#29741] [PATCH 2/2] gnu: services: web: Add service for httpd Christopher Baines
2017-12-16 20:12 ` [bug#29741] [PATCH] gnu: services: web: Add service for apache-httpd Christopher Baines
2018-01-11 9:46 ` [bug#29741] [PATCH 2/2] gnu: services: web: Add service for httpd Ludovic Courtès
2018-01-17 8:45 ` bug#29741: " Christopher Baines
2017-12-24 18:08 ` [bug#29741] [PATCH 2/2] gnu: services: web: Add service for apache-httpd Christopher Baines
2017-12-18 10:02 ` [bug#29741] [PATCH 1/2] gnu: tests: web: Generalise the test data for the nginx test Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi6gtkhx.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=29741@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.