From: ludo@gnu.org (Ludovic Courtès)
To: Paul Garlick <pgarlick@tourbillion-technology.com>
Cc: 33059-done@debbugs.gnu.org
Subject: bug#33059: [PATCH v2 0/9] Add the FEniCS Project, v2 patches
Date: Wed, 14 Nov 2018 21:38:48 +0100 [thread overview]
Message-ID: <87zhubcs2v.fsf@gnu.org> (raw)
In-Reply-To: <1542038441-5738-1-git-send-email-pgarlick@tourbillion-technology.com> (Paul Garlick's message of "Mon, 12 Nov 2018 16:00:32 +0000")
Hello Paul and all,
Paul Garlick <pgarlick@tourbillion-technology.com> skribis:
> Hi Efraim, Hi Eric, Hi Ludo,
>
> Thank you for your comments on the patch series for the FEniCS Project
> packages. I have been able to make changes to address all of the
> suggestions with one exception, noted below.
>
> The main differences between the original and v2 patches are:
>
> i) python-mpi4py is now part of (gnu packages mpi)
> ii) python-petsc4py is now part of (gnu packages maths)
> iii) python-slepc4py is now part of (gnu packages maths)
> iv) temporary directory changes use 'with-directory-excursion'
> v) 'substitute*' is used in preference to 'with-atomic-file-replacement'
> vi) the Guix 'catch' package is used in preference to the bundled version
> vii) the 'python-fenics-dolfin' package has been renamed 'fenics'
> viii) the 'fenics' package has an updated home-page and synopsis
>
> The remaining suggestion was in the 'fenics-dolfin' package:
>
>> + (string-append
>> + "set(CTEST_CUSTOM_TESTS_IGNORE "
>> + "demo_bcs_serial "
>> + "demo_bcs_mpi "
>> + "demo_eigenvalue_serial "
>> + "demo_eigenvalue_mpi "
>> + "demo_navier-stokes_serial "
>
>> Could we avoid listing all the files here?
>
> I tried a few ideas to avoid listing the demos to ignore. These are the ones
> with the 'git-lfs' links. However, this proved to be awkward.
>
> The source code lists the demos that cmake expects to be present. So, one
> may either make a list of demos to ignore (as in the original patch) or delete
> the same members from a list to include (plus delete the subdirectories
> themselves). Simply deleting the subdirectories from the build directory does
> not work. Since they exist as Makefile targets they are re-created by the
> 'make demos' step.
>
> I think the original method is preferable. An advantage is that users may
> readily access the demos if they are using Guix on a host system that has
> a git-lfs package available.
Thanks a lot for taking the time to address the comments we made on this
patch series. I’ve applied the whole series on ‘master’; everything
lints and builds for me on x86_64-linux (there are new versions of the
PETSc and SLEPSc bindings available, BTW.)
Thank you!
Ludo’.
next prev parent reply other threads:[~2018-11-14 20:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 9:17 [bug#33059] [PATCH 00/10] Add the FEniCS Project Paul Garlick
2018-10-16 9:31 ` [bug#33059] [PATCH 01/10] gnu: Add python-mpi4py Paul Garlick
2018-10-16 9:31 ` [bug#33059] [PATCH 02/10] gnu: Add python-petsc4py Paul Garlick
2018-10-24 21:45 ` Ludovic Courtès
2018-10-16 9:31 ` [bug#33059] [PATCH 03/10] gnu: Add python-slepc4py Paul Garlick
2018-10-24 21:46 ` Ludovic Courtès
2018-10-16 9:31 ` [bug#33059] [PATCH 04/10] gnu: Add python-fenics-dijitso Paul Garlick
2018-10-16 18:30 ` Efraim Flashner
2018-10-17 9:09 ` Paul Garlick
2018-10-24 21:48 ` Ludovic Courtès
2018-10-16 9:31 ` [bug#33059] [PATCH 05/10] gnu: Add python-fenics-ufl Paul Garlick
2018-10-24 21:52 ` Ludovic Courtès
2018-10-16 9:31 ` [bug#33059] [PATCH 06/10] gnu: Add python-fenics-fiat Paul Garlick
2018-10-24 21:53 ` Ludovic Courtès
2018-10-16 9:31 ` [bug#33059] [PATCH 07/10] gnu: Add python-fenics-ffc Paul Garlick
2018-10-24 21:55 ` Ludovic Courtès
2018-10-16 9:31 ` [bug#33059] [PATCH 08/10] gnu: Add fenics-dolfin Paul Garlick
2018-10-24 22:12 ` Ludovic Courtès
2018-10-16 9:31 ` [bug#33059] [PATCH 09/10] gnu: Add python-fenics-dolfin Paul Garlick
2018-10-24 22:15 ` Ludovic Courtès
2018-10-16 9:31 ` [bug#33059] [PATCH 10/10] gnu: Add fenics Paul Garlick
2018-10-24 22:17 ` Ludovic Courtès
2018-11-12 16:00 ` [bug#33059] [PATCH v2 0/9] Add the FEniCS Project, v2 patches Paul Garlick
2018-11-12 16:00 ` [bug#33059] [PATCH v2 1/9] gnu: Add python-mpi4py Paul Garlick
2018-11-12 16:00 ` [bug#33059] [PATCH v2 2/9] gnu: Add python-petsc4py Paul Garlick
2018-11-12 16:00 ` [bug#33059] [PATCH v2 3/9] gnu: Add python-slepc4py Paul Garlick
2018-11-12 16:00 ` [bug#33059] [PATCH v2 4/9] gnu: Add python-fenics-dijitso Paul Garlick
2018-11-12 16:00 ` [bug#33059] [PATCH v2 5/9] gnu: Add python-fenics-ufl Paul Garlick
2018-11-12 16:00 ` [bug#33059] [PATCH v2 6/9] gnu: Add python-fenics-fiat Paul Garlick
2018-11-14 21:11 ` Ludovic Courtès
2018-11-12 16:00 ` [bug#33059] [PATCH v2 7/9] gnu: Add python-fenics-ffc Paul Garlick
2018-11-12 16:00 ` [bug#33059] [PATCH v2 8/9] gnu: Add fenics-dolfin Paul Garlick
2018-11-12 16:00 ` [bug#33059] [PATCH v2 9/9] gnu: Add fenics Paul Garlick
2018-11-14 20:38 ` Ludovic Courtès [this message]
2018-10-19 16:03 ` [bug#33059] [PATCH 01/10] gnu: Add python-mpi4py Eric Bavier
2018-10-22 8:51 ` Paul Garlick
2018-10-24 21:44 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhubcs2v.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=33059-done@debbugs.gnu.org \
--cc=pgarlick@tourbillion-technology.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.