From: Pierre Langlois <pierre.langlois@gmx.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 44515-done@debbugs.gnu.org, Pierre Langlois <pierre.langlois@gmx.com>
Subject: bug#44515: [PATCH] gnu: xmlstarlet: Install symlink to xmlstarlet binary.
Date: Thu, 19 Nov 2020 20:03:13 +0000 [thread overview]
Message-ID: <87zh3d867y.fsf@gmx.com> (raw)
In-Reply-To: <87o8jui8x0.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]
Hi Ludo'
Ludovic Courtès writes:
> Hi,
>
> Pierre Langlois <pierre.langlois@gmx.com> skribis:
>
>> I recently encountered a small script incompatibility between Guix and
>> other distros (Arch, Fedora, Debian) because the `xml' binary is often
>> either moved or symlinked to `xmlstarlet'.
>>
>> So here's a patch that adds the symlink, is that OK to commit?
>
> Sure! Maybe add a comment above stating that several other distros do
> that.
>
>>>From a285bc89eb37a5aa56d444c195d9ef013a30aeec Mon Sep 17 00:00:00 2001
>> From: Pierre Langlois <pierre.langlois@gmx.com>
>> Date: Fri, 30 Oct 2020 11:57:35 +0000
>> Subject: [PATCH] gnu: xmlstarlet: Install symlink to xmlstarlet binary.
>>
>> * gnu/packages/xml.scm (xmlstarlet)[arguments]: Add 'symlink-xmlstarlet
>> phase.
>
> [...]
>
>> + (add-after 'install 'symlink-xmlstarlet
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let* ((out (assoc-ref outputs "out"))
>> + (bin (string-append out "/bin")))
>> + (symlink (string-append bin "/xml")
> ^
> "xml" is enough.
Oh cool, thanks for the review! Pushed with
b04198a1477f9d685d674a1dcc81b79b530fc409.
Thanks,
Pierre
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]
prev parent reply other threads:[~2020-11-19 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 11:15 [bug#44515] [PATCH] gnu: xmlstarlet: Install symlink to xmlstarlet binary Pierre Langlois
2020-11-18 22:42 ` Ludovic Courtès
2020-11-19 20:03 ` Pierre Langlois [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh3d867y.fsf@gmx.com \
--to=pierre.langlois@gmx.com \
--cc=44515-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.