From: "Ludovic Courtès" <ludo@gnu.org>
To: Rick Huijzer <ikbenrickhuyzer@gmail.com>
Cc: r0man <roman@burningswell.com>, 57071@debbugs.gnu.org
Subject: bug#57071: Xscreensaver not working since latest patch
Date: Tue, 09 Aug 2022 23:30:58 +0200 [thread overview]
Message-ID: <87zggd14vh.fsf@gnu.org> (raw)
In-Reply-To: <CAGXOz9a6Kq5e69cwsHwDcDVvk1+_FMZPQN9A7kGs5F3iqbTApg@mail.gmail.com> (Rick Huijzer's message of "Tue, 9 Aug 2022 10:04:17 +0200")
Hi Rick,
Rick Huijzer <ikbenrickhuyzer@gmail.com> skribis:
> The latest xscreensaver patch <https://issues.guix.gnu.org/56597> rendered
> xscreensaver unusable on my systems. When I try to unlock my screen I am
> greeted with the message 'xscreensaver: don't login as root', even though I
> don't invoke it as root.
>
>
> $xscreensaver-command -lock
> Aug 9 08:45:22 localhost shepherd[1]: [slim] xscreensaver-gfx: 08:45:22:
> 1: running as root: not launching hacks.
> Aug 9 09:10:29 localhost shepherd[1]: [slim] xscreensaver-command: locking
> Aug 9 09:10:32 localhost shepherd[1]: [slim] xscreensaver-gfx: 09:10:32:
> 0: running as root: not launching hacks.
>
> When I remove the
> (screen-locker-service xscreensaver)
> I run into all kinds of set-uid problems.
Sorry about that, I built it during review but did not actually run it.
One effect of ‘screen-locker-service’ is to make the program setuid-root
so that it can authenticate users. It would seem that something changed
in xscreensaver in that area; quoth ‘driver/subprocs.c’:
--8<---------------cut here---------------start------------->8---
if (getuid() == (uid_t) 0 || geteuid() == (uid_t) 0)
/* Prior to XScreenSaver 6, if running as root, we would change the
effective uid to the user "nobody" or "daemon" or "noaccess",
but even that was just encouraging bad behavior. Don't log in
as root. */
{
fprintf (stderr, "%s: %d: running as root: not launching hacks.\n",
blurb(), ssi->number);
screenhack_obituary (ssi, "", "XScreenSaver: Don't log in as root.");
goto DONE;
}
--8<---------------cut here---------------end--------------->8---
OTOH the ‘disavow_privileges’ function is supposed to drop root
privileges early on.
So I’m not sure how it’s supposed to be run. R0man, ideas?
Thanks,
Ludo’.
next prev parent reply other threads:[~2022-08-09 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 8:04 bug#57071: Xscreensaver not working since latest patch Rick Huijzer
2022-08-09 21:30 ` Ludovic Courtès [this message]
2022-08-10 6:37 ` Roman Scherer
2022-08-10 11:54 ` Rick Huijzer
2022-08-11 13:59 ` Ludovic Courtès
2022-08-29 13:22 ` Ludovic Courtès
2023-04-13 16:03 ` Tory S. Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zggd14vh.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=57071@debbugs.gnu.org \
--cc=ikbenrickhuyzer@gmail.com \
--cc=roman@burningswell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.