From: Mathieu Othacehe <othacehe@gnu.org>
To: Grigory Shepelev <shegeley@gmail.com>
Cc: 57375@debbugs.gnu.org
Subject: [bug#57375] [PATCH] gnu: fix cups 'install-cups-filters-symlinks phase
Date: Fri, 26 Aug 2022 16:07:07 +0200 [thread overview]
Message-ID: <87zgfrxfn8.fsf@gnu.org> (raw)
In-Reply-To: <99c00ae2-d938-1b56-ef67-2bbfb4d38797@gmail.com> (Grigory Shepelev's message of "Wed, 24 Aug 2022 10:46:39 +0300")
Hey Grigory,
> (symlink f
> - (string-append out "/lib/cups/filter"
> + (string-append out "/lib/cups/filter/"
> (basename f))))
> (find-files (string-append cups-filters "/lib/cups/filter")))
Thanks for this first contribution! This fix looks fine.
However, the cups package has a lot of dependants (as shown by guix
refresh -l cups). This patch should target core-updates. On that branch,
the package definition has been a bit reworked. Do you think you could
rebase your patch on top of that branch and check that it still works
fine?
Another point, you should write a commit message using the ChangeLog
format. You can find more information here:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html.
You should also use the "git format-patch" command to preserve the
commit data such as author, commit message and so on.
Don't hesitate to ask for help if needed.
Mathieu
next prev parent reply other threads:[~2022-08-26 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 7:46 [bug#57375] [PATCH] gnu: fix cups 'install-cups-filters-symlinks phase Grigory Shepelev
2022-08-26 14:07 ` Mathieu Othacehe [this message]
2023-01-03 22:21 ` Maxim Cournoyer
[not found] ` <handler.57375.B.16613272157962.ack@debbugs.gnu.org>
2023-10-19 4:24 ` [bug#57375] Acknowledgement ([PATCH] gnu: fix cups 'install-cups-filters-symlinks phase) Grigory Shepelev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgfrxfn8.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=57375@debbugs.gnu.org \
--cc=shegeley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.