From: "Ludovic Courtès" <ludo@gnu.org>
To: Nicolas Graves <ngraves@ngraves.fr>
Cc: Nicolas Graves via <help-guix@gnu.org>
Subject: Re: managing waiting patches
Date: Mon, 05 Sep 2022 21:45:37 +0200 [thread overview]
Message-ID: <87zgfd1u72.fsf@gnu.org> (raw)
In-Reply-To: <874jylgjoj.fsf@ngraves.fr> (Nicolas Graves's message of "Wed, 10 Aug 2022 00:02:04 +0200")
Hi,
Nicolas Graves <ngraves@ngraves.fr> skribis:
> Is there a requirement to help with patch reviewing? I feel I can tackle
> python or rust packages unless they are weird, I need not to spend too
> much time on that, but if it's just advising new beginners (I'm myself
> a 9 month old Guix user but went cold turkey on my main machine, while
> my first patches were a nightmare, now I hope/believe they are quite
> clean) or trying to patch and build locally for <1h a day, with
> proper guidelines I might be able to help here.
Your help reviewing would be much welcome.
Currently there’s no strict “requirement” to help with patch review, but
the manual reads this (info "(guix) Commit Access"):
One last thing: the project keeps moving forward because committers not
only push their own awesome changes, but also offer some of their time
_reviewing_ and pushing other people’s changes. As a committer, you’re
welcome to use your expertise and commit rights to help other
contributors, too!
That hasn’t had the desired effect though—still too few reviewers among
the ~40 committers. I’m not opposed to discussing whether to turn it
into a “requirement”. A hot topic for those of us who’ll be in Paris
soonish!
Ludo’.
next prev parent reply other threads:[~2022-09-05 19:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 22:59 managing waiting patches Nicolas Graves via
2022-08-09 20:54 ` Ludovic Courtès
2022-08-09 22:02 ` Nicolas Graves via
2022-09-05 19:45 ` Ludovic Courtès [this message]
2022-09-09 17:08 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgfd1u72.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=help-guix@gnu.org \
--cc=ngraves@ngraves.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.