From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 60068@debbugs.gnu.org
Subject: [bug#60068] [PATCH 1/2] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable.
Date: Wed, 14 Dec 2022 13:25:06 -0500 [thread overview]
Message-ID: <87zgbp3ksd.fsf@gmail.com> (raw)
In-Reply-To: <875yeec57z.fsf@nckx> (Tobias Geerinckx-Rice's message of "Wed, 14 Dec 2022 17:16:19 +0100")
Hi Tobias,
Tobias Geerinckx-Rice <me@tobias.gr> writes:
> Hi Maxim,
>
> Nice! More steps towards world domination.
Eh :-)
> Maxim Cournoyer 写道:
>> +# Environment variables
>
> These sound like they should be command-line arguments.
I agree, but that'd require a loop, or GNU getopt, and I'm not motivated
enough in the moment to re-design it :-). When we get there, we could
add an --uninstall option too.
> […]
>
> Actually, I'm not totally sold on GUIX_ALLOW_OVERWRITE. It's not
> solving much a problem.
The problem it solves for me was that I needed to use 'guix pack'd
dependencies such as gpg, glibc for getent, and shadow's
groupadd/useradd, etc. to satisfy the install script dependencies on my
weird target OS (minimal busybox embedded OS); which are needed to be
unpacked under /gnu, thus conflicting with the requirement that /gnu
doesn't exist.
I tried a relocatable pack, but it didn't work, at least for gpg (file
not found error).
> Instead, the error message could be specific about what it considers a
> ‘previous Guix installation’ — which would be a good idea regardless —
> and tell the admin exactly what needs to be removed to continue.
>
>> "groupadd"
>> + "useradd"
>
> Good catch, but separate patch. (♪)
OK!
>> - if [[ -e "/var/guix" || -e "/gnu" ]]; then
>> + if [[ -z $GUIX_ALLOW_OVERWRITE && (-e /var/guix || -e /gnu) ]];
>> then
>> die "A previous Guix installation was found. Refusing
>> to overwrite."
>> + else
>> + _msg "${WAR}Overwriting existing installation!"
>> fi
>> cd "$tmp_path"
>> - tar --extract --file "$pkg" && _msg "${PAS}unpacked archive"
>> -
>> _msg "${INF}Installing /var/guix and /gnu..."
>> - mv "${tmp_path}/var/guix" /var/
>> - mv "${tmp_path}/gnu" /
>> + tar --extract --file "$pkg" -C /
>
> I'm still in favour of using something like ‘mktemp -d /gnu.XXXXXX’
> here if there's no security flaw I missed. WDYT?
>
> If the overwrite functionality is kept, we should remove the old
> directories before re-populating them.
Hopefully the reason the above makes more sense is also covered by my
use case explanation above.
Is the use case/change motivation a bit clearer now?
--
Thanks,
Maxim
next prev parent reply other threads:[~2022-12-14 18:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 15:56 [bug#60068] [PATCH 1/2] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable Maxim Cournoyer
2022-12-14 15:56 ` [bug#60069] [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require Maxim Cournoyer
2022-12-14 16:37 ` Tobias Geerinckx-Rice via Guix-patches via
2022-12-14 18:17 ` Maxim Cournoyer
2022-12-14 18:33 ` Maxim Cournoyer
2022-12-14 16:16 ` [bug#60068] [PATCH 1/2] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable Tobias Geerinckx-Rice via Guix-patches via
2022-12-14 18:25 ` Maxim Cournoyer [this message]
2023-02-04 4:36 ` Maxim Cournoyer
2022-12-14 20:46 ` [bug#60068] [PATCH v2 1/3] guix-install.sh: Add missing "useradd" command Maxim Cournoyer
2022-12-14 20:46 ` [bug#60068] [PATCH v2 2/3] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable Maxim Cournoyer
2022-12-15 14:43 ` [bug#60068] bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require Ludovic Courtès
2022-12-16 5:07 ` [bug#60069] " Maxim Cournoyer
2022-12-15 14:44 ` [bug#60068] bug#60069: " Ludovic Courtès
2022-12-14 20:46 ` [bug#60068] [PATCH v2 3/3] " Maxim Cournoyer
2022-12-15 14:41 ` [bug#60068] bug#60069: [PATCH 2/2] " Ludovic Courtès
2022-12-16 5:24 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgbp3ksd.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=60068@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.