all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: reza <reza@housseini.me>
Cc: 62473@debbugs.gnu.org, 62473-done@debbugs.gnu.org
Subject: [bug#62473] [PATCH 0/4] OpenFoam update to version 10
Date: Thu, 10 Aug 2023 09:48:12 +0200	[thread overview]
Message-ID: <87zg2zmj7n.fsf_-_@gnu.org> (raw)
In-Reply-To: <01020188ef5c39ae-e41f2b42-59d3-4e3b-886f-238c53bc915a-000000@eu-west-1.amazonses.com> (reza@housseini.me's message of "Sat, 24 Jun 2023 21:42:58 +0000")

Hi reza,

Finally pushed as 997b38badaee20a1c60411e5e599e260e47785ec.

I had to fix a number of things: line endings were still DOS-style,
requiring a manual edit, a module import was missing, there was a typo
“which "sh"” (without parens) that I changed to just "sh", there was a
circular dependency caused by engineering.scm that needed to be fixed,
and the synopsis of ‘openfoam-com’ had been left unchanged contrary to
what we had discussed.

So quite a lot of work.  Please pay more attention to review feedback
next time so we can more quickly process patches.

The good news is that this new version of OpenFoam is in now, yay!

Thanks,
Ludo’.




  reply	other threads:[~2023-08-10  7:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <72b2df6b746dd57835376346f3966e8cb38b95db.1687642326.git.reza@housseini.me>
     [not found] ` <48fed060df48bc46823360bcbb80c2b49393a51f.1687642326.git.reza@housseini.me>
2023-06-24 21:42   ` [bug#62473] [PATCH v4 2/2] gnu: Add openfoam-com reza via Guix-patches via
2023-08-10  7:48     ` Ludovic Courtès [this message]
2023-08-10 10:23       ` [bug#62473] [PATCH 0/4] OpenFoam update to version 10 Hilton Chain via Guix-patches via
     [not found] <b45be3d6737e0f394961a5ad345501d790518a9a.1683187409.git.reza@housseini.me>
2023-05-04  8:04 ` [bug#62473] [PATCH v3 1/4] gnu: Add ftest reza via Guix-patches via
2023-06-15 21:56   ` [bug#62473] [PATCH 0/4] OpenFoam update to version 10 Ludovic Courtès
     [not found] <cover.1680707361.git.reza@housseini.me>
     [not found] ` <8e459feaf2d6a3d0f8720e72299e81259b9e6168.1680707361.git.reza@housseini.me>
2023-04-05 18:21   ` [bug#62473] [PATCH v2 1/4] gnu: Add ftest reza via Guix-patches via
2023-04-06 14:29     ` [bug#62473] [PATCH 0/4] OpenFoam update to version 10 Ludovic Courtès
     [not found]       ` <72de2b1c-2a2d-c640-6246-caaf71e62263@housseini.me>
2023-04-06 14:42         ` reza via Guix-patches via
2023-04-18 20:06           ` Ludovic Courtès
     [not found] ` <622cad546298d2bd56fc4baf49dafeb8c9fa20b1.1680707361.git.reza@housseini.me>
2023-04-05 18:21   ` [bug#62473] [PATCH v2 2/4] gnu: utfcpp: Update to 3.2.3 reza via Guix-patches via
2023-04-06 14:30     ` [bug#62473] [PATCH 0/4] OpenFoam update to version 10 Ludovic Courtès
     [not found] ` <d4b6b174d56867b447ac5cff1aa02c3fea055fa0.1680707361.git.reza@housseini.me>
2023-04-05 18:21   ` [bug#62473] [PATCH v2 3/4] gnu: Add openfoam-org reza via Guix-patches via
2023-04-06 14:33     ` [bug#62473] [PATCH 0/4] OpenFoam update to version 10 Ludovic Courtès
     [not found]       ` <1061a4d6-ea54-6437-9e28-a64c3c091b0a@housseini.me>
2023-04-06 14:46         ` reza via Guix-patches via
     [not found] ` <83f2db8384fdd419a9a75a4f00338a1fbbab52b4.1680707361.git.reza@housseini.me>
2023-04-05 18:21   ` [bug#62473] [PATCH v2 4/4] gnu: Add openfoam-com reza via Guix-patches via
2023-04-06 14:36     ` [bug#62473] [PATCH 0/4] OpenFoam update to version 10 Ludovic Courtès
     [not found]       ` <ed4f586d-4bbf-61e3-4f88-97d81882bf7b@housseini.me>
2023-04-06 14:52         ` reza via Guix-patches via
2023-04-18 20:09           ` Ludovic Courtès
     [not found] <cover.1679863907.git.reza@housseini.me>
2023-03-26 20:53 ` reza via Guix-patches via
2023-03-27 16:51   ` reza via Guix-patches via
2023-08-10 15:40   ` reza via Guix-patches via
2024-02-15  9:38   ` Hartmut Goebel
     [not found]     ` <ac391026-3182-6d3a-f727-3785dbbe880f@housseini.me>
2024-02-16 21:12       ` reza via Guix-patches via
     [not found]     ` <5d41ffce-773d-0a69-6290-735d6f3989c3@housseini.me>
2024-02-17 10:01       ` reza via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zg2zmj7n.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=62473-done@debbugs.gnu.org \
    --cc=62473@debbugs.gnu.org \
    --cc=reza@housseini.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.