From: ludo@gnu.org (Ludovic Courtès)
To: Mike Gerwitz <mtg@gnu.org>
Cc: 29480-done@debbugs.gnu.org
Subject: bug#29480: [PATCH] gnu: Add xautolock.
Date: Thu, 30 Nov 2017 15:56:11 +0100 [thread overview]
Message-ID: <87y3mn3jec.fsf@gnu.org> (raw)
In-Reply-To: <87zi7786b0.fsf@gnu.org> (Mike Gerwitz's message of "Mon, 27 Nov 2017 21:50:59 -0500")
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
Hello Mike,
Mike Gerwitz <mtg@gnu.org> skribis:
> Building this one was a history lesson. I modeled it after xfig, which
> also uses imake.
Heheh.
> From 9de0820982f89949f943c1566c7dffe6b3bc87de Mon Sep 17 00:00:00 2001
> From: Mike Gerwitz <mtg@gnu.org>
> Date: Mon, 27 Nov 2017 21:45:11 -0500
> Subject: [PATCH] gnu: Add xautolock.
>
> * gnu/packages/xdisorg.scm (xautolock): New variable.
I took the liberty to make the changes below: the first one to make sure
‘xmkmf’ failures stop the process, and the second one to make sure the
phase returns a Boolean value.
Thank you!
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1102 bytes --]
diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index cc84884b6..2e1ed2ee9 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -1358,7 +1358,7 @@ or playing a PCM encoded WAVE file.")
(let ((imake (assoc-ref inputs "imake"))
(out (assoc-ref outputs "out")))
;; Generate Makefile
- (zero? (system* "xmkmf"))
+ (invoke "xmkmf")
(substitute* "Makefile"
;; These imake variables somehow remain undefined
(("DefaultGcc2[[:graph:]]*Opt") "-O2")
@@ -1369,7 +1369,8 @@ or playing a PCM encoded WAVE file.")
;; Old BSD-style 'union wait' is unneeded (defining
;; _USE_BSD did not seem to fix it)
(substitute* "src/engine.c"
- (("union wait status") "int status = 0")))))
+ (("union wait status") "int status = 0"))
+ #t)))
(add-after 'install 'install/man
(lambda _
(zero? (system* "make" "install.man")))))))
next prev parent reply other threads:[~2017-11-30 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 2:50 [bug#29480] [PATCH] gnu: Add xautolock Mike Gerwitz
2017-11-30 14:56 ` Ludovic Courtès [this message]
2017-12-02 0:44 ` Mike Gerwitz
2017-12-02 10:02 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3mn3jec.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=29480-done@debbugs.gnu.org \
--cc=mtg@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.