From: ludo@gnu.org (Ludovic Courtès)
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 29483@debbugs.gnu.org
Subject: [bug#29483] [PATCH] services: Add openntpd service.
Date: Sun, 04 Mar 2018 23:21:21 +0100 [thread overview]
Message-ID: <87y3j732ji.fsf@gnu.org> (raw)
In-Reply-To: <20180304180243.GB1521@macbook41> (Efraim Flashner's message of "Sun, 4 Mar 2018 20:02:43 +0200")
Hello,
Efraim Flashner <efraim@flashner.co.il> skribis:
> On Fri, Mar 02, 2018 at 05:46:30PM +0100, Ludovic Courtès wrote:
[...]
>> To be clear, the switch from ‘match-lambda’ to ‘match-record’ should be
>> entirely mechanical. The above snippet would become:
>>
>> (define (openntpd-shepherd-service config)
>> (match-record config <openntpd-configuration>
>> (openntpd openntpd-listen-on
>> openntpd-query-from openntpd-sensor openntpd-server
>> openntpd-servers openntpd-constraint-from
>> openntpd-constraints-from allow-large-adjustment?)
>> …))
>>
>> That’s all I was suggesting. The body of that procedure can remain
>> unchanged.
>>
>> Does that make sense?
>>
>
> Yes, that does make sense. Switching helped me find that I mistakenly
> used openntpd-<var> when it should've just been <var>, so I've fixed
> that. I've also added a default value field, like the ones that were
> recently added for the SQL services, and I tested that it worked with
> (service openntpd-service-type) in my test config.
Awesome.
> From 0c4d07cce671ad9131416f51098082286f241046 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Tue, 28 Nov 2017 10:19:11 +0200
> Subject: [PATCH] services: Add openntpd service.
>
> * gnu/packages/ntp.scm (openntpd)[arguments]: Add 'configure-flags to
> set openntpd daemon's user and localstatedir. Add a custom phase to not
> try to create said directory at install time.
> * gnu/services/networking.scm (<openntpd-configuration>): New record type.
> (openntpd-shepherd-service, openntpd-service-activation): New procedures.
> (openntpd-service-type): New variable.
> * doc/guix.texi (Networking Services): Add openntpd documentation.
[...]
> + (constraints-from openntpd-constriants-from
^^
Typo. :-)
Got for it!
Thank you,
Ludo’.
next prev parent reply other threads:[~2018-03-04 22:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 9:04 [bug#29483] [PATCH] services: Add openntpd service Efraim Flashner
2017-12-01 10:19 ` Ludovic Courtès
2018-01-11 21:44 ` Ludovic Courtès
2018-01-19 23:52 ` Ludovic Courtès
[not found] ` <20180129192423.GC17751@macbook41>
[not found] ` <871shzbgoz.fsf@gnu.org>
2018-03-02 14:02 ` Efraim Flashner
2018-03-02 16:46 ` Ludovic Courtès
2018-03-04 18:02 ` Efraim Flashner
2018-03-04 22:21 ` Ludovic Courtès [this message]
2017-12-03 19:24 ` Marius Bakke
2018-03-05 9:32 ` bug#29483: " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3j732ji.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=29483@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.