From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 34982-done@debbugs.gnu.org
Subject: bug#34982: [PATCH] guile-build-system: Support building in parallel.
Date: Fri, 19 Apr 2019 08:43:39 +0100 [thread overview]
Message-ID: <87y346tp78.fsf@cbaines.net> (raw)
In-Reply-To: <87ftqheoj6.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Christopher Baines <mail@cbaines.net> skribis:
>
>> * guix/build/guile-build-system.scm (build): Use invoke-each, instead of
>> for-each, to use multiple cores if available.
>> (invoke-each, report-build-process): New procedures.
>
> [...]
>
>> + (define (fork-and-run-command command)
>> + (match (primitive-fork)
>> + (0
>> + (apply execlp command))
>> + (pid
>> + #t)))
>
> To be on the safe side, you should probably wrap the ‘execlp’ call like
> this:
>
> (dynamic-wind
> (const #t)
> (lambda ()
> (apply execlp command))
> (lambda ()
> (primitive-exit 127)))
>
> This ensures that the child process exits immediately if something goes
> wrong (e.g., ‘execlp’ raises an exception because the executable could
> not be found.)
>
> Otherwise LGTM, thank you!
Great, I've added in dynamic-wind, made some minor tweaks to the output,
and pushed this as 3fdb9a375f1cee7dd302349a9527437df20b3f61.
Thanks for taking a look :)
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
prev parent reply other threads:[~2019-04-19 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 21:23 [bug#34982] [PATCH] guile-build-system: Support building in parallel Christopher Baines
2019-03-30 10:56 ` Ludovic Courtès
2019-04-05 23:33 ` Christopher Baines
2019-04-05 23:50 ` [bug#34982] " Christopher Baines
2019-04-16 17:06 ` Ludovic Courtès
2019-04-16 18:25 ` Christopher Baines
2019-04-16 18:13 ` Christopher Baines
2019-04-16 19:30 ` Ludovic Courtès
2019-04-19 7:43 ` Christopher Baines [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y346tp78.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=34982-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.