all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches <guix-patches@gnu.org>
To: 36824@debbugs.gnu.org
Subject: [bug#36824] [PATCH] gnu: Add oshu.
Date: Sun, 28 Jul 2019 18:07:10 +0200	[thread overview]
Message-ID: <87y30if8i9.fsf@nckx> (raw)
In-Reply-To: <a7e9ac17-c288-7882-ab84-b6c4c1d435a6@cs.ru.nl>

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

Dan,

Thanks!  I'm deprived of Guix for the moment, so I can't review 
the package itself.  Looks good on first glance, though.

Dan Frumin 写道:
>    (synopsis "Clone of the Osu! rhythm game")
>    (description "Oshu! is a free clone of the Osu! rhythm game, 
>    designed to

I'd rather see a 'first-class' description of what this game is 
and does and drop the 'is a clone of' part entirely: 'is capable 
of playing the original Osu! beatmaps' already says it all without 
implying it's some kind of knock-off ;-)

If you don't have time fo' that I understand, but you're 
presumably familiar with both games & in the best position to 
write something accurate.

> be run on GNU/Linux without requiring a powerful videocard. 
> Oshu! is capable

s/videocard/video card/, or graphics card.  Is it really tied to 
the kernel?  (Not entirely implausible considering the real-time 
audio nature.  Interesting design, by the way.)

> of playing the original Osu! beatmaps (not included in this 
> package). ")

Could we package these separately?  How are they licenced?

>    (license license:gpl3)))

Ugh, no licence headers?  I guess that does make it GPL 3-only, 
but I'm no expert.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2019-07-28 16:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-27 18:18 [bug#36824] [PATCH] gnu: Add oshu Dan Frumin
2019-07-28 11:42 ` Dan Frumin
2019-07-28 16:07   ` Tobias Geerinckx-Rice via Guix-patches [this message]
     [not found] ` <handler.36824.B.15642515427371.ack@debbugs.gnu.org>
2019-07-29 11:32   ` Dan Frumin
2019-07-29 13:20     ` Ricardo Wurmus
2019-07-29 13:29       ` Tobias Geerinckx-Rice via Guix-patches
2021-02-20 19:07         ` Leo Prikler
2021-02-21  0:36           ` Leo Prikler
2021-02-24  0:06             ` bug#36824: " Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y30if8i9.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=36824@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.