From: Marius Bakke <mbakke@fastmail.com>
To: Danny Milosavljevic <dannym@scratchpost.org>, guix-devel@gnu.org
Subject: Re: branch master updated: gnu: gnome-todo: Fix build.
Date: Wed, 06 May 2020 17:43:18 +0200 [thread overview]
Message-ID: <87y2q5m5m1.fsf@devup.no> (raw)
In-Reply-To: <20200506153829.27942.8541@vcs0.savannah.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1569 bytes --]
Hi Danny,
guix-commits@gnu.org writes:
> commit b17b29454d5edd61eecb4536461789b7a3865a9a
> Author: Danny Milosavljevic <dannym@scratchpost.org>
> AuthorDate: Wed May 6 17:36:03 2020 +0200
>
> gnu: gnome-todo: Fix build.
>
> * gnu/packages/patches/gnome-todo-delete-esource-duplicate.patch: New file.
> * gnu/packages/gnome.scm (gnome-todo)[source]: Add it.
> * gnu/local.mk (dist_patch_DATA): Add it.
Thanks for fixing GNOME Todo!
[...]
> diff --git a/gnu/packages/patches/gnome-todo-delete-esource-duplicate.patch b/gnu/packages/patches/gnome-todo-delete-esource-duplicate.patch
> new file mode 100644
> index 0000000..9e9c2e2
> --- /dev/null
> +++ b/gnu/packages/patches/gnome-todo-delete-esource-duplicate.patch
> @@ -0,0 +1,7 @@
> +--- gnome-todo-3.28.1/plugins/eds/gtd-eds-autoptr.h.orig 2020-05-06 14:20:49.589902539 +0200
> ++++ gnome-todo-3.28.1/plugins/eds/gtd-eds-autoptr.h 2020-05-06 14:20:54.593919721 +0200
> +@@ -25,4 +25,3 @@
> + G_DEFINE_AUTOPTR_CLEANUP_FUNC (ECalComponent, g_object_unref);
> + G_DEFINE_AUTOPTR_CLEANUP_FUNC (ECalComponentId, e_cal_component_free_id);
> + G_DEFINE_AUTOPTR_CLEANUP_FUNC (ECalClient, g_object_unref);
> +-G_DEFINE_AUTOPTR_CLEANUP_FUNC (ESource, g_object_unref);
Can you add a short comment at the top of the patch file explaining what
this does, along with links to relevant upstream commits/issues (if
applicable)?
That way future packagers don't have to reverse-engineer your patch to
figure out what it does / whether it is still needed.
TIA! :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next parent reply other threads:[~2020-05-06 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200506153829.27942.8541@vcs0.savannah.gnu.org>
2020-05-06 15:43 ` Marius Bakke [this message]
2020-05-06 16:12 ` branch master updated: gnu: gnome-todo: Fix build Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2q5m5m1.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.