From: "Ludovic Courtès" <ludo@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 60010@debbugs.gnu.org
Subject: bug#60010: [version 1.4.0] AMD screen stays black; modprobe fails
Date: Thu, 15 Dec 2022 00:29:32 +0100 [thread overview]
Message-ID: <87y1r9r2cj.fsf@gnu.org> (raw)
In-Reply-To: <87r0x2f62t.fsf@pelzflorian.de> (pelzflorian@pelzflorian.de's message of "Wed, 14 Dec 2022 14:49:46 +0100")
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>> Do you see hints as to whether uvesafb gets loaded?
>>
>> You can do that by adding “console=ttyS0” to the kernel arguments and by
>> passing ‘-serial stdio’ to QEMU.
>
> This serial output shows nothing about uvesafb, but dmesg contains about
> uvesafb exactly the same modprobe failure as initially without
> LINUX_MODULE_DIRECTORY.
Oooh. ‘invoke’ uses ‘system*’, and in shepherd 0.9.3, ‘system*’ is
implemented in terms of ‘fork+exec-command’, which only passes the
environment variables listed in ‘default-environment-variables’ by
default. Thus, (setenv "LINUX_MODULE_DIRECTORY" …) had no effect on the
child process; it just wouldn’t see LINUX_MODULE_DIRECTORY.
I think the patch below will be good… or very close to it.
Lemme know!
Thanks,
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1433 bytes --]
diff --git a/gnu/system/install.scm b/gnu/system/install.scm
index f6f1923121..e524729baf 100644
--- a/gnu/system/install.scm
+++ b/gnu/system/install.scm
@@ -289,11 +289,21 @@ (define (uvesafb-shepherd-service _)
(provision '(maybe-uvesafb))
(requirement '(file-systems))
(start #~(lambda ()
- (or (file-exists? "/dev/fb0")
+ (unless (file-exists? "/dev/fb0")
+ ;; In shepherd 0.9.3, 'system*' is implemented in terms
+ ;; of 'fork+exec-command'. Thus, set
+ ;; 'default-environment-variables' to pass an extra
+ ;; variable to the child process.
+ (parameterize ((default-environment-variables
+ `("LINUX_MODULE_DIRECTORY=/run/booted-system/kernel/lib/modules"
+ ,(environ))))
+ ;; TODO: Use 'load-linux-modules-from-directory'
+ ;; instead.
(invoke #+(file-append kmod "/bin/modprobe")
"uvesafb"
(string-append "v86d=" #$v86d "/sbin/v86d")
- "mode_option=1024x768"))))
+ "mode_option=1024x768"))
+ #t)))
(respawn? #f)
(one-shot? #t))))
next prev parent reply other threads:[~2022-12-14 23:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 16:27 bug#60010: [version 1.4.0] AMD screen stays black; modprobe fails pelzflorian (Florian Pelz)
2022-12-12 20:11 ` Josselin Poiret via Bug reports for GNU Guix
2022-12-13 12:29 ` pelzflorian (Florian Pelz)
2022-12-12 23:18 ` Ludovic Courtès
2022-12-13 10:00 ` Ludovic Courtès
2022-12-13 12:50 ` pelzflorian (Florian Pelz)
2022-12-13 13:03 ` Ludovic Courtès
2022-12-14 13:49 ` pelzflorian (Florian Pelz)
2022-12-14 23:29 ` Ludovic Courtès [this message]
2022-12-15 17:42 ` pelzflorian (Florian Pelz)
2022-12-15 23:37 ` Ludovic Courtès
2022-12-16 11:48 ` pelzflorian (Florian Pelz)
2022-12-13 13:51 ` pelzflorian (Florian Pelz)
2022-12-13 16:37 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1r9r2cj.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=60010@debbugs.gnu.org \
--cc=pelzflorian@pelzflorian.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.