From: "Ludovic Courtès" <ludo@gnu.org>
To: Nicolas Graves <ngraves@ngraves.fr>
Cc: 60518-done@debbugs.gnu.org
Subject: bug#60518: [PATCH] gnu: spirv-cross: Activate tests.
Date: Tue, 31 Jan 2023 23:57:03 +0100 [thread overview]
Message-ID: <87y1piqpmo.fsf@gnu.org> (raw)
In-Reply-To: <20230103154820.28860-1-ngraves@ngraves.fr> (Nicolas Graves's message of "Tue, 3 Jan 2023 16:48:20 +0100")
Hi,
Nicolas Graves <ngraves@ngraves.fr> skribis:
> * gnu/packages/vulkan.scm (spirv-cross):
> [arguments]: Add phase update-reference-shaders.
> [arguments]: Activate tests.
Applied, thanks!
Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
> Am Dienstag, dem 03.01.2023 um 16:48 +0100 schrieb Nicolas Graves:
>> * gnu/packages/vulkan.scm (spirv-cross):
>> [arguments]: Add phase update-reference-shaders.
>> [arguments]: Activate tests.
> Should be
>
> * gnu/packages/vulkan.scm (spirv-cross)[arguments]: Remove #:tests?.
> <#:phases>: Add ‘update-reference-shaders’.
I did that on their behalf (in general I think that’s what we should do,
it’s just more efficient and less frustrating for everyone).
>> + (lambda _
>> + (with-directory-excursion "../source"
>> + (invoke "./update_test_shaders.sh")))))))
> Instead of updating all the shaders, should we perhaps only update
>
> the three that are mentioned as failing?
Apparently the script is designed for this purpose.
Thanks,
Ludo’.
prev parent reply other threads:[~2023-01-31 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 15:48 [bug#60518] [PATCH] gnu: spirv-cross: Activate tests Nicolas Graves via Guix-patches via
2023-01-03 19:51 ` Liliana Marie Prikler
2023-01-31 22:57 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1piqpmo.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=60518-done@debbugs.gnu.org \
--cc=ngraves@ngraves.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.