From: "Ludovic Courtès" <ludo@gnu.org>
To: soeren@soeren-tempel.net
Cc: 68675@debbugs.gnu.org
Subject: [bug#68675] [PATCH v2] gnu: Add dhcpcd.
Date: Mon, 12 Feb 2024 22:32:52 +0100 [thread overview]
Message-ID: <87y1bpbc6z.fsf@gnu.org> (raw)
In-Reply-To: <2156325d2caa8d4298c9828d84fa5fff40592da4.1706123111.git.soeren@soeren-tempel.net> (soeren@soeren-tempel.net's message of "Wed, 24 Jan 2024 20:05:11 +0100")
Hi,
soeren@soeren-tempel.net skribis:
> From: Sören Tempel <soeren@soeren-tempel.net>
>
> * gnu/packages/admin.scm (dhcpcd): new procedure.
>
> Signed-off-by: Sören Tempel <soeren@soeren-tempel.net>
Overall LGTM modulo minor stylistic issues:
> + #:configure-flags #~(list "--enable-ipv6"
> + "--enable-privsep"
> + "--privsepuser=dhcpcd"
> + (string-append "--dbdir=" "/var/db/dhcpcd")
> + (string-append "--rundir=" "/var/run/dhcpcd")
> + "CC=gcc")
Should be (string-append "CC=" #$(cc-for-target)).
> + (add-before 'build 'setenv
> + (lambda _
> + (setenv "HOST_SH"
> + (string-append #$bash-minimal "/bin/sh"))))
Rather (setenv "HOST_SH" (which "sh")).
That way users can still override the shell used by the package.
> + (add-after 'install 'wrap-hooks
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (libexec (string-append out "/libexec"))
> + (sed (assoc-ref inputs "sed"))
> + (coreutils (assoc-ref inputs "coreutils")))
Rather (search-input-file inputs "/bin/sed") and likewise for coreutils,
and then…
> + (wrap-program (string-append libexec
> + "/dhcpcd-run-hooks")
> + `("PATH" ":" suffix
> + (,(string-append coreutils "/bin")
> + ,(string-append sed "/bin"))))))))))
… use (dirname sed) and (dirname ls), say, to get their /bin directory.
This is more robust than relying on the input label.
Ludo’.
next prev parent reply other threads:[~2024-02-12 21:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 16:12 [bug#68675] [PATCH] Support dhcpcd in dhcp-client-service-type soeren
2024-01-23 16:14 ` [bug#68675] [PATCH] gnu: Add dhcpcd soeren
2024-01-23 16:14 ` [bug#68675] [PATCH] services: dhcp: Support the dhcpcd implementation soeren
2024-01-23 19:52 ` [bug#68675] [PATCH] Support dhcpcd in dhcp-client-service-type Sergey Trofimov
2024-01-24 19:11 ` Sören Tempel
2024-01-24 19:05 ` [bug#68675] [PATCH v2] gnu: Add dhcpcd soeren
2024-01-24 19:05 ` [bug#68675] [PATCH v2] services: dhcp: Support the dhcpcd implementation soeren
2024-02-12 21:41 ` Ludovic Courtès
2024-02-13 12:52 ` Sören Tempel
2024-02-28 20:46 ` Ludovic Courtès
2024-02-12 21:32 ` Ludovic Courtès [this message]
2024-02-13 12:50 ` [bug#68675] [PATCH v3 1/2] gnu: Add dhcpcd soeren
2024-02-13 12:50 ` [bug#68675] [PATCH v3 2/2] services: dhcp: Support the dhcpcd implementation soeren
2024-02-28 20:53 ` Ludovic Courtès
2024-03-11 9:10 ` Sören Tempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1bpbc6z.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=68675@debbugs.gnu.org \
--cc=soeren@soeren-tempel.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.