From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 22050@debbugs.gnu.org
Subject: bug#22050: [PATCH v5 2/2] services: base: Use make-static-device-nodes.
Date: Fri, 15 Dec 2017 10:44:22 +0100 [thread overview]
Message-ID: <87wp1ol409.fsf@gnu.org> (raw)
In-Reply-To: <20171214212548.655-3-dannym@scratchpost.org> (Danny Milosavljevic's message of "Thu, 14 Dec 2017 22:25:48 +0100")
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> * gnu/services/base.scm (udev-shepherd-service): Use make-static-device-nodes.
> ---
> gnu/services/base.scm | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/base.scm b/gnu/services/base.scm
> index 291dd6325..34699cdcd 100644
> --- a/gnu/services/base.scm
> +++ b/gnu/services/base.scm
> @@ -1727,6 +1727,14 @@ item of @var{packages}."
> (setenv "EUDEV_RULES_DIRECTORY"
> #$(file-append rules "/lib/udev/rules.d"))
>
> + (let* ((kernel-release
> + (utsname:release (uname)))
^
Indentation.
> + (linux-module-directory
> + (getenv "LINUX_MODULE_DIRECTORY"))
> + (linux-release-module-directory
> + (string-append linux-module-directory "/"
> + kernel-release)))
> + (make-static-device-nodes linux-release-module-directory))
Nitpick: I think ‘directory’ would be good enough as an identifier to
this local variable.
Otherwise LGTM!
prev parent reply other threads:[~2017-12-15 9:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-29 11:36 bug#22050: fuse.ko not automatically loaded on GuixSD Ludovic Courtès
2017-12-13 22:04 ` bug#22050: [PATCH 0/2] Create static device nodes before starting udev Danny Milosavljevic
2017-12-13 22:05 ` bug#22050: [PATCH 1/2] linux-boot: Add make-static-device-nodes Danny Milosavljevic
2017-12-13 22:05 ` bug#22050: [PATCH 2/2] services: base: Use make-static-device-nodes Danny Milosavljevic
2017-12-13 22:17 ` bug#22050: [PATCH v2 0/2] Create static device nodes before starting udev Danny Milosavljevic
2017-12-13 22:17 ` bug#22050: [PATCH v2 1/2] linux-boot: Add make-static-device-nodes Danny Milosavljevic
2017-12-13 22:17 ` bug#22050: [PATCH v2 2/2] services: base: Use make-static-device-nodes Danny Milosavljevic
2017-12-13 22:32 ` bug#22050: [PATCH v3 0/2] Create static device nodes before starting udev Danny Milosavljevic
2017-12-13 22:32 ` bug#22050: [PATCH v3 1/2] linux-boot: Add make-static-device-nodes Danny Milosavljevic
2017-12-14 8:52 ` Ludovic Courtès
2017-12-14 10:32 ` Danny Milosavljevic
2017-12-14 13:14 ` Ludovic Courtès
2017-12-14 18:21 ` Danny Milosavljevic
2017-12-13 22:32 ` bug#22050: [PATCH v3 2/2] services: base: Use make-static-device-nodes Danny Milosavljevic
2017-12-14 19:56 ` bug#22050: [PATCH v4 0/2] Create static device nodes before starting udev Danny Milosavljevic
2017-12-14 19:56 ` bug#22050: [PATCH v4 1/2] linux-boot: Add make-static-device-nodes Danny Milosavljevic
2017-12-15 9:41 ` Ludovic Courtès
2017-12-15 17:27 ` Danny Milosavljevic
2017-12-15 22:37 ` Ludovic Courtès
2017-12-14 19:56 ` bug#22050: [PATCH v4 2/2] services: base: Use make-static-device-nodes Danny Milosavljevic
2017-12-14 21:25 ` bug#22050: [PATCH v5 0/2] Create static device nodes before starting udev Danny Milosavljevic
2017-12-14 21:25 ` bug#22050: [PATCH v5 1/2] linux-boot: Add make-static-device-nodes Danny Milosavljevic
2017-12-14 21:25 ` bug#22050: [PATCH v5 2/2] services: base: Use make-static-device-nodes Danny Milosavljevic
2017-12-15 9:44 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp1ol409.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=22050@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.