From: Mark H Weaver <mhw@netris.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 30006@debbugs.gnu.org
Subject: bug#30006: bzip2 does not provide libbz2.so
Date: Fri, 23 Mar 2018 16:50:22 -0400 [thread overview]
Message-ID: <87woy234a9.fsf@netris.org> (raw)
In-Reply-To: <718583be2617e43743e8ee40397bb0b4@tobias.gr> (Tobias Geerinckx-Rice's message of "Fri, 23 Mar 2018 13:19:33 +0100")
Hi,
Tobias Geerinckx-Rice <me@tobias.gr> writes:
> On 2018-03-23 13:02, Marius Bakke wrote:
>> diff --git a/gnu/packages/compression.scm
>> b/gnu/packages/compression.scm
>> index b158feac4..fd111e579 100644
>> --- a/gnu/packages/compression.scm
>> +++ b/gnu/packages/compression.scm
>> @@ -272,6 +272,9 @@ file; as a result, it is often used in
>> conjunction with \"tar\", resulting in
>> (lambda* (#:key outputs #:allow-other-keys)
>> (let* ((out (assoc-ref outputs "out"))
>> (libdir (string-append out "/lib")))
>> + ;; The Make target above does not create "libbz2.so", only
>> + ;; the versioned libs, so we have to create it ourselves.
>> + (symlink "libbz2.so.1.0" "libbz2.so")
>
> How about symlinking to (string-append ... version) directly?
> Seems more robust & worked fine when I tried it, I think.™
In general, the version numbers at the end of shared library names like
"libbz2.so.1.0" do not necessarily match the version number of the
corresponding source release. Therefore, I don't think we should write
code that assumes that those two versions will coincide.
However, I agree that it would be better not to hardcode the "1.0". I
would suggest using 'find-files' to find the versioned shared library,
and to verify that there is exactly one match. (ice-9 match) provides
an elegant way to check for a singleton list while matching its element.
What do you think?
Thanks for working on it.
Mark
next prev parent reply other threads:[~2018-03-23 20:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 13:29 bug#30006: bzip2 does not provide libbz2.so Ludovic Courtès
2018-03-23 12:02 ` Marius Bakke
2018-03-23 12:19 ` Tobias Geerinckx-Rice
2018-03-23 12:38 ` Marius Bakke
2018-03-24 17:01 ` Ludovic Courtès
2018-03-26 17:36 ` Marius Bakke
2018-03-27 7:32 ` Ludovic Courtès
2018-03-27 20:49 ` Marius Bakke
2018-03-23 20:50 ` Mark H Weaver [this message]
2018-03-24 1:17 ` Tobias Geerinckx-Rice
2018-03-24 16:54 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woy234a9.fsf@netris.org \
--to=mhw@netris.org \
--cc=30006@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.