From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: John Soo <jsoo1@asu.edu>
Cc: 40304@debbugs.gnu.org
Subject: [bug#40304] [PATCH] gnu: Add emacs-dhall-mode.
Date: Mon, 30 Mar 2020 19:24:34 +0200 [thread overview]
Message-ID: <87wo7169il.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <878sjk2byr.fsf@asu.edu> (John Soo's message of "Sat, 28 Mar 2020 18:20:44 -0700")
Hello,
John Soo <jsoo1@asu.edu> writes:
> dhall-mode provides language support for the dhall configuration
> language.
Thank you.
> +(define-public emacs-dhall-mode
> + (package
> + (name "emacs-dhall-mode")
> + (version "0.1.0")
This version is not accurate. The ".el" file mentions 0.1.3, but I think
we should use Github versioning, i.e., there is no versioning at all, so
we should do the commit + revision dance again, and use "0.1.3" as the
base of the version string.
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/psibi/dhall-mode")
> + (commit "ef4d33debe224c6ba37e51a29b9dc8b74f20f1c2")))
This should go in a dedicated variable.
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1232y2k4l3bsz90pgis78zxmrw7jv09dfaip21yc1w4vpxfyr384"))))
Nitpick: I usually put `base32' on the same line as the string.
> + (inputs
Nitpick: Emacs build system uses `propagated-inputs', although this is
the same.
> + `(("emacs-reformatter" ,emacs-reformatter)))
> + (build-system emacs-build-system)
Nitpick: `build-system' is usually above
> + (home-page "https://github.com/psibi/dhall-mode")
> + (synopsis "Major mode for working with Dhall configuration language")
> + (description
> + "Emacs Major mode for working with Dhall configuration
> language.")
The description must be a full sentence.
> + (license license:gpl2+)))
The license looks wrong. I see GPL3+ in this package.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-03-30 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 1:20 [bug#40304] [PATCH] gnu: Add emacs-dhall-mode John Soo
2020-03-30 17:24 ` Nicolas Goaziou [this message]
2020-03-30 18:39 ` John Soo
2020-03-30 20:43 ` bug#40304: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo7169il.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=40304@debbugs.gnu.org \
--cc=jsoo1@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.