all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Michael Zucchi <notzed@gmail.com>, 40918-done@debbugs.gnu.org
Cc: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
Subject: bug#40918: [PATCH] openjdk 14 package
Date: Sat, 16 May 2020 11:54:01 +0200	[thread overview]
Message-ID: <87wo5cgq86.fsf@elephly.net> (raw)
In-Reply-To: <20200429230155.0e4f53d9@alma-ubu>

Hi Michael,

thank you for your contribution!

I’ve split the commit into two (one for each package addition), replaced
the patch with a substitution, simplified the snippet, removed unused
inputs, used libjpeg-turbo instead of libjpeg, and corrected the commit
message.

I’ve pushed the two commits to the master branch:

--8<---------------cut here---------------start------------->8---
commit 65a11a59de86fa759f2ffbb7db53430a6727c2ea
Author: Not Zed <notzed@gmail.com>

    gnu: Add openjdk14.
    
    * gnu/packages/java.scm (openjdk14): New variable.
    
    Signed-off-by: Ricardo Wurmus <rekado@elephly.net>

commit c4618174ecb6375849529f1d1026585817bb139e
Author: Not Zed <notzed@gmail.com>

    gnu: Add openjdk13.
    
    * gnu/packages/java.scm (openjdk13): New variable.
    
    Signed-off-by: Ricardo Wurmus <rekado@elephly.net>
--8<---------------cut here---------------end--------------->8---

Thanks again!

-- 
Ricardo




      reply	other threads:[~2020-05-16  9:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28  1:26 [bug#40918] [PATCH] openjdk 14 package Michael Zucchi
2020-04-28  1:34 ` [bug#40918] update Michael Zucchi
2020-04-28 22:38 ` [bug#40918] [PATCH] openjdk 14 package Björn Höfling
2020-04-28 23:47   ` Michael Zucchi
2020-04-29 21:01     ` Björn Höfling
2020-05-16  9:54       ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wo5cgq86.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=40918-done@debbugs.gnu.org \
    --cc=bjoern.hoefling@bjoernhoefling.de \
    --cc=notzed@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.