From: "Ludovic Courtès" <ludo@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: 41855@debbugs.gnu.org
Subject: [bug#41855] [PATCH 1/2] hurd-boot: Create individual translators instead of running MAKEDEV.
Date: Fri, 19 Jun 2020 10:03:25 +0200 [thread overview]
Message-ID: <87wo43h48i.fsf@gnu.org> (raw)
In-Reply-To: <87y2omyap0.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Tue, 16 Jun 2020 23:15:07 +0200")
Hi,
Jan Nieuwenhuizen <janneke@gnu.org> skribis:
>> It’s counter-intuitive that hurd-boot.scm is used from GNU/Linux.
>> Should we move the shared bits in (gnu build hurd) or similar?
>
> Maybe...I don't know. hurd-boot defines functions that are needed to
> create a bootable hurd -- some can be called from GNU/Linux.
>
> Similarly, "linux-boot" defines "make-essential-device-nodes", which
> could be called from GNU/Hurd when we cross build a linux VM.
Right.
> Well, having one weird situation is a bad argument to propagate the
> madness.
>
> I guess it makes sense to move utility functions like
> passive-translator-xattr, passive-translator-installed?, and translated?
> could be moved to (gnu build hurd).
>
> Haven't made this change yet, let me know you want; or feel free to make
> the change yourself :-)
Yeah, we can leave that for later. :-)
> From 1e27aabb8bf32e85547517e1f0e35f789a08933d Mon Sep 17 00:00:00 2001
> From: "Jan (janneke) Nieuwenhuizen" <janneke@gnu.org>
> Date: Mon, 8 Jun 2020 13:02:13 +0200
> Subject: [PATCH v2 1/2] hurd-boot: Create individual translators instead of
> running MAKEDEV.
>
> * guix/build/utils.scm
Something’s wrong!
> * gnu/build/hurd-boot.scm (make-hurd-device-nodes): Do not create
> dev/{null,zero,full,random,urandom} mount points.
> (passive-translator-xattr?, passive-translator-installed?, translated?,
> set-hurd-device-translators): New procedures.
> (false-if-EEXIST): New macro.
> (boot-hurd-system): Use them instead of running MAKEDEV.
[...]
> +(define* (set-translator! file-name command #:optional (mode #o600))
Nitpick: there shouldn’t be a bang here (just like for ‘mkdir’, etc.).
Otherwise LGTM, thank you!
Ludo’.
next prev parent reply other threads:[~2020-06-19 8:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 16:54 bug#41855: [PATCH 0/2] hurd-boot: Cleanups: Remove MAKEDEV, then use setxattr (on the Hurd) Jan (janneke) Nieuwenhuizen
2020-06-14 16:56 ` bug#41855: [PATCH 1/2] hurd-boot: Create individual translators instead of running MAKEDEV Jan (janneke) Nieuwenhuizen
2020-06-14 16:56 ` bug#41855: [PATCH 2/2] hurd-boot: Use 'setxattr' instead of invoking settrans Jan (janneke) Nieuwenhuizen
2020-06-15 20:00 ` Ludovic Courtès
2020-06-16 21:12 ` [bug#41855] " Jan Nieuwenhuizen
2020-06-15 19:54 ` bug#41855: [PATCH 1/2] hurd-boot: Create individual translators instead of running MAKEDEV Ludovic Courtès
2020-06-16 21:15 ` [bug#41855] " Jan Nieuwenhuizen
2020-06-19 8:03 ` Ludovic Courtès [this message]
2020-06-19 8:44 ` bug#41855: " Jan Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo43h48i.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=41855@debbugs.gnu.org \
--cc=janneke@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.