all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: ludo@gnu.org (Ludovic Courtès)
Cc: 30053-done@debbugs.gnu.org, Steve Sprang <steve.sprang@gmail.com>,
	Roel Janssen <roel@gnu.org>
Subject: bug#30053: [PATCH 1/3] Improve appearance of tabular output.
Date: Thu, 15 Jul 2021 16:15:12 -0400	[thread overview]
Message-ID: <87wnprbagf.fsf_-_@gmail.com> (raw)
In-Reply-To: <871r7zcwdr.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Thu,  15 Jul 2021 13:36:16 -0400")

Hi again,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hi,
>
> Here's an improved version of the first patch.  It now uses a hard limit
> on the maximum width of a column, which is a poor man's way of getting
> rid of the outliers that cause the table to be too wide in some
> situations (such as in 'guix package -A').
>
> Otherwise the performance remain unchanged (from ~2 to ~7 seconds with
> 'guix package -A' on a fast machine).
>
>
>
> Thanks!
>
> Maxim

I've improved it some more and pushed as 01d7e8c278.  The performance is
about 5 s on a fast machines to format the 18000 something packages of
the collection, compared to 2 s before (guix package -A), which I think
is OK (but it'd be nice to see Guile opitimize for faster (ice-9
format)!).

Closing.

Thanks to all involved!

Maxim




  reply	other threads:[~2021-07-15 20:16 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 22:34 [bug#30053] [PATCH 1/3] Improve appearance of tabular output Steve Sprang
2018-01-09 22:37 ` [bug#30053] [PATCH 2/3] " Steve Sprang
2018-01-09 22:37 ` [bug#30053] [PATCH 3/3] " Steve Sprang
2018-01-11 21:32 ` [bug#30053] [PATCH 1/3] " Ludovic Courtès
2018-01-11 23:32   ` Steve Sprang
2018-01-12 13:28     ` Roel Janssen
2018-01-13 19:59       ` Steve Sprang
2018-01-16 14:16         ` Ludovic Courtès
2018-01-16 23:56           ` Steve Sprang
2021-07-15  5:39           ` Maxim Cournoyer
2021-07-15 17:36             ` [bug#30053] [PATCH 1/3 v2] " Maxim Cournoyer
2021-07-15 20:15               ` Maxim Cournoyer [this message]
2021-07-21 16:56               ` [bug#30053] [PATCH 1/3] " Ludovic Courtès
2021-07-21 21:43                 ` Maxim Cournoyer
2021-07-15 22:05             ` Sarah Morgensen via Guix-patches via
2021-07-16  1:25               ` Maxim Cournoyer
2018-01-12 14:56   ` Danny Milosavljevic
2018-01-12 15:26     ` Leo Famulari
2018-01-12 15:50       ` bug#30087: "guix package -A" hangs with attached package set Danny Milosavljevic
2020-12-03  0:10         ` zimoun
2020-12-22 16:12           ` zimoun
2021-01-11 12:29             ` zimoun
2018-01-13 13:47       ` [bug#30053] [PATCH 1/3] Improve appearance of tabular output Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnprbagf.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=30053-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=roel@gnu.org \
    --cc=steve.sprang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.