all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: jgart <jgart@dismail.de>
Cc: Brice Waegeneire <brice@waegenei.re>,
	Arun Isaac <arunisaac@systemreboot.net>,
	50275-done@debbugs.gnu.org, Julien Lepiller <julien@lepiller.eu>
Subject: bug#50275: [PATCH 1/4] gnu: Add go-github-com-gdamore-tcell-v2.
Date: Mon, 30 Aug 2021 14:57:30 -0400	[thread overview]
Message-ID: <87wno2lq05.fsf@gmail.com> (raw)
In-Reply-To: <20210830164041.19770-1-jgart@dismail.de> (jgart@dismail.de's message of "Mon, 30 Aug 2021 12:40:38 -0400")

Hello!

jgart <jgart@dismail.de> writes:

> From: Guix Together <jgart@dismail.de>
>
> * gnu/packages/golang.scm (go-github-com-gdamore-tcell-v2): New variable.
>
> Co-authored-by: Arun Isaac <arunisaac@systemreboot.net>
> Co-authored-by: Brice Waegeneire <brice@waegenei.re>
> Co-authored-by: jgart <jgart@dismail.de>
> Co-authored-by: Julien Lepiller <julien@lepiller.eu>

This is awesome!

> ---
>  gnu/packages/golang.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index 72579d6bd2..f52343345b 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -5257,6 +5257,38 @@ formatting.  It also favors portability, and includes support for all POSIX
>  systems.")
>        (license license:expat))))
>  
> +(define-public go-github-com-gdamore-tcell-v2
> +    (package
> +      (inherit go-github-com-gdamore-tcell)
> +      (name "go-github-com-gdamore-tcell")
> +      (version "2.3.1")
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/gdamore/tcell")
> +               (commit (string-append "v" version))))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> +           "0ypbl5080q9sd3irad8mv7zlg4242i8pmg5xyhbyq95kymwibaid"))))
> +      (arguments
> +       `(#:import-path "github.com/gdamore/tcell/v2"
> +         #:phases
> +         (modify-phases %standard-phases
> +           (add-before 'reset-gzip-timestamps 'make-files-writable
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               ;; Make sure .gz files are writable so that the
> +               ;; 'reset-gzip-timestamps' phase can do its work.
> +               (let ((out (assoc-ref outputs "out")))
> +                 (for-each make-file-writable
> +                           (find-files out "\\.gz$"))
> +                 #t))))))

Note that you can preemptively start loosing the trailing #t; the
warning will vanish after the guix-core-updates-frozen branch is merged
into master.

> +      (propagated-inputs
> +       `(("go-golang-org-x-term" ,go-golang-org-x-term)
> +         ("go-golang-org-x-sys" ,go-golang-org-x-sys)
> +         ,@(package-inputs go-github-com-gdamore-tcell)))))
> +
>  (define-public go-github-com-mattn-go-shellwords
>    (let ((commit "2444a32a19f450fabaa0bb3e96a703f15d9a97d2")
>          (version "1.0.5")

LGTM.  I fixed the license of the parent package (it should have been
Apache 2.0) and pushed as cc71a54e9f900e905192f794c7bc5346c445e651.

Closing.

Maxim




      parent reply	other threads:[~2021-08-30 18:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 16:40 [bug#50275] [PATCH 1/4] gnu: Add go-github-com-gdamore-tcell-v2 jgart via Guix-patches via
2021-08-30 16:40 ` [bug#50276] [PATCH 2/4] gnu: Add go-github-com-anaseto-gruid-tcell jgart via Guix-patches via
2021-08-30 19:35   ` bug#50276: " Maxim Cournoyer
2021-08-30 16:40 ` [bug#50277] [PATCH 3/4] gnu: Add go-github-com-anaseto-gruid jgart via Guix-patches via
2021-09-12  0:53   ` [bug#50277] This one can be closed since it was merged jgart via Guix-patches via
2021-09-12  3:05     ` bug#50277: " Maxim Cournoyer
2021-08-30 16:40 ` [bug#50278] [PATCH 4/4] gnu: harmonist: Update to 0.4.1 jgart via Guix-patches via
     [not found]   ` <handler.50278.B.16303417037327.ack@debbugs.gnu.org>
2021-08-30 16:54     ` [bug#50278] Acknowledgement ([PATCH 4/4] gnu: harmonist: Update to 0.4.1.) jgart via Guix-patches via
2021-08-30 18:41       ` [bug#50278] [PATCH 4/4] gnu: harmonist: Update to 0.4.1 Maxim Cournoyer
2021-08-30 19:47   ` bug#50278: " Maxim Cournoyer
2021-08-30 18:57 ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wno2lq05.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=50275-done@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    --cc=brice@waegenei.re \
    --cc=jgart@dismail.de \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.