[bug#60905] [PATCH 08/25] gnu: go-github-com-pkg-diff: Update to 0.0.0-20210226163009-20ebb0f2a09e.

[Christopher Baines <mail@cbaines.net>]

[-- Attachment #1: Type: text/plain, Size: 2872 bytes --]


Katherine Cox-Buday <cox.katherine.e@gmail.com> writes:

> * gnu/packages/golang.scm (go-github-com-pkg-diff): Update to 0.0.0-20210226163009-20ebb0f2a09e.
> ---
>  gnu/packages/golang.scm | 44 +++++++++++++++++++----------------------
>  1 file changed, 20 insertions(+), 24 deletions(-)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index 9554234c7b..5e8159975f 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -8736,30 +8736,26 @@ (define-public go-github-com-go-git-go-git-fixtures
>      (license license:asl2.0)))
>  
>  (define-public go-github-com-pkg-diff
> -  (let ((commit "531926345625d489a6b56f860a569e68245ace36")
> -        (revision "1"))
> -    (package
> -      (name "go-github-com-pkg-diff")
> -      (version (git-version "0.0.1" revision commit))
> -      (source (origin
> -                (method git-fetch)
> -                (uri (git-reference
> -                      (url "https://github.com/pkg/diff")
> -                      (commit commit)))
> -                (file-name (git-file-name name version))
> -                (sha256
> -                 (base32
> -                  "1770m7qhww6lm0wj1v3mhv6hwa2v92p4w2fqxj1xyrg5dd58d944"))))
> -      (build-system go-build-system)
> -      (arguments
> -       `(#:import-path "github.com/pkg/diff"))
> -      (native-inputs
> -       (list go-github-com-sergi-go-diff))
> -      (home-page "https://github.com/pkg/diff/")
> -      (synopsis "Create and print diffs")
> -      (description
> -       "This package provides a Go library to create and print diffs.")
> -      (license license:bsd-3))))
> +  (package
> +    (name "go-github-com-pkg-diff")
> +    (version "0.0.0-20210226163009-20ebb0f2a09e")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/pkg/diff")
> +                    (commit "20ebb0f2a09e612109b224b32f79370409108bcc")))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1g3dzgwhz4fx3ddpsv7fsa4r1v5clsp2lbw2qrkdk9y1vc5gi8yi"))))
> +    (build-system go-build-system)
> +    (arguments
> +     `(#:import-path "github.com/pkg/diff"))
> +    (home-page "https://github.com/pkg/diff/")
> +    (synopsis "Create and print diffs")
> +    (description
> +     "This package provides a Go library to create and print diffs.")
> +    (license license:bsd-3)))
>  
>  (define-public go-github-com-twpayne-go-shell
>    (package

I'm not sure I prefer the longer version here, and also having the
commit in the origin but then part of it in the version makes this a
little harder to update since you have to update both bits.

What led you to change from using the (let ((... bit here?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]