all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Csepp <raingloom@riseup.net>
To: Christopher Baines <mail@cbaines.net>
Cc: 60673@debbugs.gnu.org, raingloom@riseup.net
Subject: [bug#60673] [PATCH 01/39] gnu: Add ocaml-domain-name.
Date: Wed, 08 Feb 2023 02:37:48 +0100	[thread overview]
Message-ID: <87wn4t2aik.fsf@riseup.net> (raw)
In-Reply-To: <874jrxdhxi.fsf@cbaines.net>


Christopher Baines <mail@cbaines.net> writes:

> [[PGP Signed Part:Undecided]]
> Hey,
>
> While I think the builds look OK for this series, there are quite a few
> formatting issues raised by the linter (this can be seen on [1] and [2]).
>
> 1: https://qa.guix.gnu.org/issue/60674
> 2:
> https://data.qa.guix.gnu.org/compare?base_commit=238f965c331990459a69cbc713ca951ad40e6044&target_commit=3b5485b9cdaebda127dc040ad67a287f39e33519
>
> Could you run the linter on the packages you've added here, address the
> issues it raises and send an updated series?
>
> Thanks,
>
> Chris
>
> [[End of PGP Signed Part]]

Those are all URL constants, can't really do much about them other than slice
them up with string-append, which I'm not sure really helps with
readability or ease of editing.  They were not an issue while I was
editing the code and gnu/packages/ocaml.scm already has a lot of lines
that whitespace-mode highlights as too long, so I thought it wouldn't
matter much and my time would be better spent elsewhere.
The real fix IMHO would be to convert them into git-fetch origins, which
would also make it possible to use git related package transforms.  This
is on my TODO list.
Or at least the OPAM importer should be changed to do the URL splitting.




  reply	other threads:[~2023-02-08  1:48 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09  0:34 [bug#60673] [PATCH 01/39] gnu: Add ocaml-domain-name Csepp
2023-01-09  0:34 ` [bug#60671] [PATCH 02/39] gnu: Add ocaml-macaddr Csepp
2023-01-09  0:34 ` [bug#60672] [PATCH 03/39] gnu: Add ocaml-ipaddr Csepp
2023-01-09  0:34 ` [bug#60674] [PATCH 04/39] gnu: Add ocaml-opam-monorepo Csepp
2023-01-09  0:34 ` [bug#60675] [PATCH 05/39] gnu: Add ocaml-pecu Csepp
2023-01-09  0:34 ` [bug#60676] [PATCH 06/39] gnu: Add ocaml-emile Csepp
2023-01-09  0:34 ` [bug#60677] [PATCH 07/39] gnu: Add ocaml-functoria-runtime Csepp
2023-01-09  0:34 ` [bug#60678] [PATCH 08/39] gnu: Add ocaml-mirage-runtime Csepp
2023-01-09  0:34 ` [bug#60679] [PATCH 09/39] gnu: Add ocaml-functoria Csepp
2023-01-09  0:35 ` [bug#60680] [PATCH 10/39] gnu: Add ocaml-mirage Csepp
2023-01-09  0:35 ` [bug#60681] [PATCH 11/39] gnu: Add ocaml-duration Csepp
2023-01-09  0:35 ` [bug#60682] [PATCH 12/39] gnu: Add ocaml-mirage-unix Csepp
2023-01-09  0:35 ` [bug#60683] [PATCH 13/39] gnu: Add ocaml-mirage-time Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 14/39] gnu: Add aliases for ocaml-cstruct and ocaml-lwt subpackages Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 15/39] gnu: Add ocaml-ppx-cstruct Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 16/39] gnu: Add ocaml-mirage-profile-unix Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 17/39] gnu: Add ocaml-mirage-profile Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 18/39] gnu: Add ocaml-mirage-clock Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 19/39] gnu: Add ocaml-ptime Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 20/39] gnu: Add ocaml-mirage-logs Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 21/39] gnu: Add ocaml-sexp-pretty Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 22/39] gnu: Add ocaml-expect-test-helpers-core Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 23/39] gnu: Add ocaml-intrinsics Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 24/39] gnu: Add ocaml-core-unix Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 25/39] gnu: Add ocaml-async-kernel Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 26/39] gnu: Add ocaml-async-unix Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 27/39] gnu: Add ocaml-textutils-kernel Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 28/39] gnu: Add ocaml-textutils Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 29/39] gnu: Add ocaml-protocol-version-header Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 30/39] gnu: Add ocaml-async-rpc-kernel Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 31/39] gnu: Add ocaml-async Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 32/39] gnu: Add ocaml-shared-memory-ring Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 33/39] gnu: Alias ocaml-shared-memory-ring-lwt to ocaml-shared-memory-ring Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 34/39] gnu: Add ocaml-xenstore Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 35/39] gnu: Add ocaml-io-page Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 36/39] gnu: Add ocaml-bheap Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 37/39] gnu: Add ocaml-mirage-xen Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 38/39] gnu: Add ocaml-parse-argv Csepp
2023-01-09  0:35 ` [bug#60673] [PATCH 39/39] gnu: Add ocaml-mirage-bootvar-unix Csepp
2023-02-07  7:57 ` [bug#60673] [PATCH 01/39] gnu: Add ocaml-domain-name Christopher Baines
2023-02-08  1:37   ` Csepp [this message]
2023-02-08  7:32     ` Christopher Baines
2023-02-17  1:03       ` Csepp
2023-02-17  6:41         ` Julien Lepiller
2023-02-17 15:50           ` Christopher Baines
2023-02-15 21:59 ` [bug#60673] Csepp
2023-02-15 21:59   ` [bug#60673] [PATCH v2 01/39] gnu: Add ocaml-domain-name Csepp
2023-02-15 21:59   ` [bug#60673] [PATCH v2 02/39] gnu: Add ocaml-macaddr Csepp
2023-02-15 21:59   ` [bug#60673] [PATCH v2 03/39] gnu: Add ocaml-ipaddr Csepp
2023-02-15 21:59   ` [bug#60673] [PATCH v2 04/39] gnu: Add ocaml-opam-monorepo Csepp
2023-02-15 21:59   ` [bug#60673] [PATCH v2 05/39] gnu: Add ocaml-pecu Csepp
2023-02-15 21:59   ` [bug#60673] [PATCH v2 06/39] gnu: Add ocaml-emile Csepp
2023-02-15 21:59   ` [bug#60673] [PATCH v2 07/39] gnu: Add ocaml-functoria-runtime Csepp
2023-02-15 21:59   ` [bug#60673] [PATCH v2 08/39] gnu: Add ocaml-mirage-runtime Csepp
2023-02-15 21:59   ` [bug#60673] [PATCH v2 09/39] gnu: Add ocaml-functoria Csepp
2023-02-15 21:59   ` [bug#60673] [PATCH v2 10/39] gnu: Add ocaml-mirage Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 11/39] gnu: Add ocaml-duration Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 12/39] gnu: Add ocaml-mirage-unix Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 13/39] gnu: Add ocaml-mirage-time Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 14/39] gnu: Add aliases for ocaml-cstruct and ocaml-lwt subpackages Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 15/39] gnu: Add ocaml-ppx-cstruct Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 16/39] gnu: Add ocaml-mirage-profile-unix Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 17/39] gnu: Add ocaml-mirage-profile Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 18/39] gnu: Add ocaml-mirage-clock Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 19/39] gnu: Add ocaml-ptime Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 20/39] gnu: Add ocaml-mirage-logs Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 21/39] gnu: Add ocaml-sexp-pretty Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 22/39] gnu: Add ocaml-expect-test-helpers-core Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 23/39] gnu: Add ocaml-intrinsics Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 24/39] gnu: Add ocaml-core-unix Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 25/39] gnu: Add ocaml-async-kernel Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 26/39] gnu: Add ocaml-async-unix Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 27/39] gnu: Add ocaml-textutils-kernel Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 28/39] gnu: Add ocaml-textutils Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 29/39] gnu: Add ocaml-protocol-version-header Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 30/39] gnu: Add ocaml-async-rpc-kernel Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 31/39] gnu: Add ocaml-async Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 32/39] gnu: Add ocaml-shared-memory-ring Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 33/39] gnu: Add ocaml-shared-memory-ring-lwt Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 34/39] gnu: Add ocaml-xenstore Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 35/39] gnu: Add ocaml-io-page Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 36/39] gnu: Add ocaml-bheap Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 37/39] gnu: Add ocaml-mirage-xen Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 38/39] gnu: Add ocaml-parse-argv Csepp
2023-02-15 22:00   ` [bug#60673] [PATCH v2 39/39] gnu: Add ocaml-mirage-bootvar-unix Csepp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn4t2aik.fsf@riseup.net \
    --to=raingloom@riseup.net \
    --cc=60673@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.