From: "Ludovic Courtès" <ludo@gnu.org>
To: Timo Wilken <guix@twilken.net>
Cc: 61774@debbugs.gnu.org
Subject: [bug#61774] [PATCH] gnu: Add luarocks.
Date: Thu, 30 Mar 2023 23:14:49 +0200 [thread overview]
Message-ID: <87wn2ygcvq.fsf@gnu.org> (raw)
In-Reply-To: <20230224224613.25630-1-guix@twilken.net> (Timo Wilken's message of "Fri, 24 Feb 2023 23:46:13 +0100")
Hi,
Timo Wilken <guix@twilken.net> skribis:
> Luarocks is a package manager for Lua modules.
>
> It is used by the Prosody XMPP server (already packaged in Guix) to
> install extensions.
>
> * gnu/packages/lua.scm (luarocks): Add variable.
Could resend the two patches merged as one?
Some comments:
> + (substitute* '("GNUmakefile" "src/luarocks/fs/unix.lua"
> + "src/luarocks/core/sysdetect.lua")
> + (("/bin/sh")
> + (string-append (assoc-ref inputs "bash-minimal")
> + "/bin/sh")))))
Rather (search-input-file inputs "/bin/sh").
> + (synopsis "A package manager for Lua modules")
I believe ‘guix lint’ will tel you to remove “A”. :-)
> + ;; The home page says:
> + ;; "LuaRocks is free software and uses the same license as Lua."
> + (license license:x11)))
Please double-check the license in the source (and remove the comment).
> + (add-after 'install 'patch-unzip
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (substitute*
> + (string-append
> + (assoc-ref outputs "out") "/etc/luarocks/config-"
> + ,(substring (package-version lua) 0 3) ".lua") ;e.g. "5.2"
> + (("variables = \\{")
> + (string-append
> + "variables = {\n"
> + " AR = \"" (assoc-ref inputs "binutils") "/bin/ar\";\n"
> + " BUNZIP2 = \"" (assoc-ref inputs "bzip2") "/bin/bunzip2\";\n"
> + " CC = \"" (assoc-ref inputs "gcc") "/bin/gcc\";\n"
> + " CHMOD = \"" (assoc-ref inputs "coreutils") "/bin/chmod\";\n"
> + " CMAKE = \"" (assoc-ref inputs "coreutils") "/bin/cmake\";\n"
These should all use ‘search-input-file’. However…
> + " CP = \"" (assoc-ref inputs "coreutils") "/bin/cp\";\n"
> + " CURL = \"" (assoc-ref inputs "curl") "/bin/curl\";\n"
> + " CVS = \"" (assoc-ref inputs "cvs") "/bin/cvs\";\n"
> + " FIND = \"" (assoc-ref inputs "findutils") "/bin/find\";\n"
> + " GIT = \"" (assoc-ref inputs "git") "/bin/git\";\n"
> + " GPG = \"" (assoc-ref inputs "gnupg") "/bin/gpg\";\n"
[...]
> + " RSYNC = \"" (assoc-ref inputs "rsync") "/bin/rsync\";\n"
> + " SCP = \"" (assoc-ref inputs "openssh") "/bin/scp\";\n"
> + " SEVENZ = \"" (assoc-ref inputs "p7zip") "/bin/7z\";\n"
> + " SVN = \"" (assoc-ref inputs "subversion") "/bin/svn\";\n"
> + " TAR = \"" (assoc-ref inputs "tar") "/bin/tar\";\n"
Does it really need all these things? What does ‘guix size luarocks’
say now?
Maybe it’s OK to assume that some of the rarely-used dependencies (say,
CVS, SVN, 7zip) will be picked from $PATH and that it will fail
otherwise? That would help keep the closure size under control.
> + (inputs (list lua bash-minimal
> + ;; Executables required by luarocks.
> + binutils bzip2 coreutils curl cvs findutils gcc git gnupg
> + gzip gnu-make mercurial openssh openssl p7zip rsync
> + subversion tar unzip wget zip))
Please one per line since there are many of them (you can run ‘guix
style luarocks’).
Could you send an updated patch?
Thanks!
Ludo’.
next prev parent reply other threads:[~2023-03-30 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 22:46 [bug#61774] [PATCH] gnu: Add luarocks Timo Wilken
2023-02-26 16:08 ` [bug#61774] [PATCH] gnu: luarocks: Add for Lua 5.2 and fix dependencies Timo Wilken
2023-03-30 21:14 ` Ludovic Courtès [this message]
2024-05-26 11:26 ` bug#61774: [PATCH] gnu: Add luarocks Andrew Tropin via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn2ygcvq.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=61774@debbugs.gnu.org \
--cc=guix@twilken.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.