all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Saku Laesvuori <saku@laesvuori.fi>
Cc: 62292-done@debbugs.gnu.org, mirai@makinata.eu
Subject: bug#62292: [PATCH] gnu: Add kitsas
Date: Mon, 17 Apr 2023 23:29:05 +0200	[thread overview]
Message-ID: <87wn2ab3ku.fsf_-_@gnu.org> (raw)
In-Reply-To: <20230322125443.6561-1-saku@laesvuori.fi> (Saku Laesvuori's message of "Wed, 22 Mar 2023 14:54:43 +0200")

Hi Saku,

Saku Laesvuori <saku@laesvuori.fi> skribis:

>     * gnu/packages/finance.scm (kitsas): New variable.

Thanks for the updated patch.  I went ahead and applied it with the
changes below (the license is ‘gpl3+’ because the ‘LICENSE’ file
explicitly says “version 3 or any later version”).

The test failures are worrisome though.  Could you investigate why those
tests are failing or crashing?

Those failures may indicate real issues.  Or it could be that they
require a running X server (other packages usually solve that by
spawning ‘Xvfb’ right before the ‘check’ phase).

Thank you, and thanks Bruno for reviewing.

Ludo’.




  reply	other threads:[~2023-04-17 21:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 10:56 [bug#62292] [PATCH] gnu: Add kitsas Saku Laesvuori via Guix-patches via
2023-03-20 18:09 ` Bruno Victal
2023-03-22 12:54 ` [bug#62292] [PATCH v2] " Saku Laesvuori via Guix-patches via
2023-04-17 21:29   ` Ludovic Courtès [this message]
2023-04-18 14:51     ` [bug#62292] [PATCH] " Saku Laesvuori via Guix-patches via
2023-04-20 10:30       ` Ludovic Courtès
2023-04-20 11:38         ` Saku Laesvuori via Guix-patches via
2023-04-20 12:37           ` Saku Laesvuori via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn2ab3ku.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=62292-done@debbugs.gnu.org \
    --cc=mirai@makinata.eu \
    --cc=saku@laesvuori.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.