From: Josselin Poiret via Bug reports for GNU Guix <bug-guix@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>, 65225@debbugs.gnu.org
Cc: "Tobias Geerinckx-Rice" <me@tobias.gr>,
"Simon Tournier" <zimon.toutoune@gmail.com>,
"Mathieu Othacehe" <othacehe@gnu.org>,
"Ludovic Courtès" <ludo@gnu.org>,
"Christopher Baines" <mail@cbaines.net>,
"Ricardo Wurmus" <rekado@elephly.net>
Subject: bug#65225: [PATCH] environment: Build the profile for the requested system.
Date: Sat, 12 Aug 2023 12:42:59 +0200 [thread overview]
Message-ID: <87wmy0mtho.fsf@jpoiret.xyz> (raw)
In-Reply-To: <871qg8o8hi.fsf@jpoiret.xyz>
[-- Attachment #1: Type: text/plain, Size: 2582 bytes --]
Hi everyone,
Actually, let me add a big erratum, since it appears I misread the
intention of gexp->derivation (and realized 2 minutes after writing the
previous email).
Josselin Poiret <dev@jpoiret.xyz> writes:
> --8<---------------cut here---------------start------------->8---
> (mlet* %store-monad ( ;; The following binding forces '%current-system' and
> ;; '%current-target-system' to be looked up at >>=
> ;; time.
> (graft? (set-grafting graft?))
>
> (system -> (or system (%current-system)))
> (target -> (if (eq? target 'current)
> (%current-target-system)
> target))
> ...)
> ...)
> --8<---------------cut here---------------end--------------->8---
>
> Well, the issue here is that such an mlet starts by translating the
> graft? binding into a >>= call, which ends up putting the rest of the
> translation into a function call that will *not* be called until the
> monadic value is run. That means that the system and target bindings
> afterwards are *not* looked up at call time but at monadic run time!
This is actually what the comment above hints at, I misunderstood its
meaning. It seems that this piece of code used to be (before 2015)
--8<---------------cut here---------------start------------->8---
(mlet* %store-monad ( ;; The following binding forces '%current-system' and
;; '%current-target-system' to be looked up at >>=
;; time.
(unused (return #f)
(system -> (or system (%current-system)))
(target -> (if (eq? target 'current)
(%current-target-system)
target))
...)
...)
--8<---------------cut here---------------end--------------->8---
probably at a time when (current-system) didn't exist. In turn, this
means that gexp->derivation intentionally delays getting the current
system to monadic run time. Thus, we probably need to pass an optional
#:system argument to the hooks that they can forward to
gexp->derivation to fix this “properly”
> IMO, this is way too complicated to keep in mind at all times, and there
> are bugs lurking under the surface absolutely everywhere, waiting for a
> corner case to be uncovered.
My comment still stands.
Best,
--
Josselin Poiret
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]
next prev parent reply other threads:[~2023-08-12 10:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 11:10 bug#65225: ‘guix shell --system=ALIEN’ builds for both systems Tobias Geerinckx-Rice via Bug reports for GNU Guix
2023-08-06 0:00 ` bug#65225: [PATCH] environment: Build the profile for the requested system Tobias Geerinckx-Rice via Bug reports for GNU Guix
2023-08-12 10:33 ` Josselin Poiret via Bug reports for GNU Guix
2023-08-12 10:42 ` Josselin Poiret via Bug reports for GNU Guix [this message]
2023-08-12 20:51 ` Ludovic Courtès
2023-10-19 14:48 ` [bug#66640] [PATCH 0/2] Build profile hooks for the right system Ludovic Courtès
2023-10-19 14:53 ` [bug#66640] [PATCH 1/2] packages: Add ‘system’ parameter for ‘set-guile-for-build’ Ludovic Courtès
2023-10-19 14:53 ` [bug#66640] [PATCH 2/2] profiles: Hooks honor the #:system parameter of ‘profile-derivation’ Ludovic Courtès
2023-10-20 22:46 ` bug#65225: ‘guix shell --system=ALIEN’ builds for both systems Maxim Cournoyer
2023-10-23 10:16 ` Simon Tournier
2023-10-23 14:29 ` Maxim Cournoyer
2023-10-23 10:36 ` bug#65225: [bug#66640] [PATCH 0/2] Build profile hooks for the right system Simon Tournier
2023-10-23 19:53 ` Ludovic Courtès
2023-10-24 18:34 ` Simon Tournier
2023-10-27 23:36 ` bug#66640: " Ludovic Courtès
2023-08-11 11:43 ` bug#65225: ‘guix shell --system=ALIEN’ builds for both systems Tobias Geerinckx-Rice via Bug reports for GNU Guix
2023-08-11 15:58 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmy0mtho.fsf@jpoiret.xyz \
--to=bug-guix@gnu.org \
--cc=65225@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=ludo@gnu.org \
--cc=mail@cbaines.net \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.