all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Fries <fries1234@protonmail.com>
Cc: GNU Debbugs <control@debbugs.gnu.org>,
	65072@debbugs.gnu.org, 65085@debbugs.gnu.org
Subject: [bug#65085] [PATCH 12/13] gnu: Add go-github-com-json-iterator-go
Date: Fri, 01 Sep 2023 08:08:22 -0400	[thread overview]
Message-ID: <87wmxa3xl5.fsf_-_@gmail.com> (raw)
In-Reply-To: <2d73f9922ae784fa47cb820b73517262ae08f52f.1691218710.git.fries1234@protonmail.com> (Fries's message of "Sat, 05 Aug 2023 07:00:11 +0000")

tags 65072 + moreinfo
quit

Hi Fries,

Thank you for your contribution.

Fries <fries1234@protonmail.com> writes:

> * gnu/packages/golang.scm (go-github-com-chyzer-test): New variable.
> ---
>  gnu/packages/golang.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index d99f76dc7d..ef82f0aa1b 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -2113,6 +2113,32 @@ (define-public go-github-com-dhowett-go-plist
>  types.")
>        (license license:giftware))))
>  
> +(define-public go-github-com-chzyer-test
> +  (package
> +    (name "go-github-com-chzyer-test")
> +    (version "1.0.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/chzyer/test")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1axdlcnx2qjsn5wsr2pr1m0w0a8k4nk5kkrngh742fgh81vzzy8s"))))
> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "github.com/chzyer/test"
> +       #:phases
> +       ;; Tests relating to a in-memory disk fail due to a Segfault.
> +       (modify-phases %standard-phases
> +         (delete 'check))))

This should be minimally investigated, and ideally an issue created on
upstream issue tracker and an URL added next to the comment to track its
resolution, e.g:

;; Tests relating to a in-memory disk fail due to a segfault (see:
;; $URL).

Also taking the comments from parens into account, could you please send
a v2 to this same issue (65072@debbugs.gnu.org) ?

-- 
Thanks,
Maxim




  parent reply	other threads:[~2023-09-01 12:09 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-05  7:00 [bug#65074] [PATCH 00/13] Add scc Fries via Guix-patches via
2023-08-05  7:00 ` [bug#65075] [PATCH 01/13] gnu: Add go-github-com-chyzer-logex Fries via Guix-patches via
2023-08-05  9:08   ` ( via Guix-patches via
2024-04-06 15:55   ` Sharlatan Hellseher
2023-08-05  7:00 ` [bug#65072] [PATCH 02/13] gnu: Add go-github-com-chyzer-test Fries via Guix-patches via
2023-08-05  9:14   ` ( via Guix-patches via
2023-09-01 12:08   ` Maxim Cournoyer [this message]
2024-04-06 15:52   ` Sharlatan Hellseher
2024-04-06 15:53   ` Sharlatan Hellseher
2023-08-05  7:00 ` [bug#65076] [PATCH 03/13] gnu: Add go-github-com-chyzer-readline Fries via Guix-patches via
2023-08-05  9:15   ` ( via Guix-patches via
2024-04-06 15:56   ` Sharlatan Hellseher
2023-08-05  7:00 ` [bug#65073] [PATCH 04/13] gnu: Add go-github-com-ianlancetaylor-demangle Fries via Guix-patches via
2023-08-05  9:16   ` ( via Guix-patches via
2024-04-06 15:53   ` Sharlatan Hellseher
2023-08-05  7:00 ` [bug#65078] [PATCH 05/13] gnu: Add go-github-com-google-pprof Fries via Guix-patches via
2023-08-05  9:18   ` ( via Guix-patches via
2023-08-05  7:00 ` [bug#65077] [PATCH 06/13] gnu: Add go-github-com-felixge-fgprof Fries via Guix-patches via
2023-08-05  9:18   ` ( via Guix-patches via
2023-08-05  7:00 ` [bug#65079] [PATCH 07/13] gnu: Add go-github-com-pkg-profile Fries via Guix-patches via
2023-08-05  9:19   ` ( via Guix-patches via
2023-08-05  7:00 ` [bug#65082] [PATCH 08/13] gnu: Add go-github-com-karrick-godirwalk Fries via Guix-patches via
2023-08-05  9:21   ` ( via Guix-patches via
2023-08-05  7:00 ` [bug#65080] [PATCH 09/13] gnu: Add go-github-com-dbaggerman-cuba Fries via Guix-patches via
2023-08-05  9:22   ` ( via Guix-patches via
2023-08-05  7:00 ` [bug#65081] [PATCH 10/13] gnu: Add go-github-com-modern-go-concurrent Fries via Guix-patches via
2023-08-05  9:24   ` ( via Guix-patches via
2023-08-05  7:00 ` [bug#65084] [PATCH 11/13] gnu: Add go-github-com-modern-go-reflect2 Fries via Guix-patches via
2023-08-05  9:24   ` ( via Guix-patches via
2023-08-05  7:01 ` [bug#65085] [PATCH 12/13] gnu: Add go-github-com-json-iterator-go Fries via Guix-patches via
2023-08-05  9:25   ` ( via Guix-patches via
2023-08-05  7:01 ` [bug#65083] [PATCH 13/13] gnu: Add scc Fries via Guix-patches via
2023-08-05  9:26   ` ( via Guix-patches via
     [not found]   ` <5f2cbbcab7bffce62f537af2912233c1b30c58a89092d9c56bdbb27a90879851@mu.id>
2023-08-05 10:01     ` ( via Guix-patches via
2023-08-05 11:01 ` [bug#65074] [PATCH v2 00/13] " Fries via Guix-patches via
2023-08-05 11:01   ` [bug#65074] [PATCH v2 01/13] gnu: Add go-github-com-chyzer-logex Fries via Guix-patches via
2023-08-05 11:01   ` [bug#65074] [PATCH v2 02/13] gnu: Add go-github-com-chyzer-test Fries via Guix-patches via
2023-08-05 11:01   ` [bug#65074] [PATCH v2 03/13] gnu: Add go-github-com-chyzer-readline Fries via Guix-patches via
2023-08-05 11:01   ` [bug#65074] [PATCH v2 04/13] gnu: Add go-github-com-ianlancetaylor-demangle Fries via Guix-patches via
2023-08-05 11:01   ` [bug#65074] [PATCH v2 05/13] gnu: Add go-github-com-google-pprof Fries via Guix-patches via
2023-08-05 11:01   ` [bug#65074] [PATCH v2 06/13] gnu: Add go-github-com-felixge-fgprof Fries via Guix-patches via
2023-08-05 11:01   ` [bug#65074] [PATCH v2 07/13] gnu: Add go-github-com-pkg-profile Fries via Guix-patches via
2023-08-05 11:01   ` [bug#65074] [PATCH v2 08/13] gnu: Add go-github-com-karrick-godirwalk Fries via Guix-patches via
2023-08-05 11:01   ` [bug#65074] [PATCH v2 09/13] gnu: Add go-github-com-dbaggerman-cuba Fries via Guix-patches via
2023-08-05 11:02   ` [bug#65074] [PATCH v2 10/13] gnu: Add go-github-com-modern-go-concurrent Fries via Guix-patches via
2023-08-05 11:02   ` [bug#65074] [PATCH v2 11/13] gnu: Add go-github-com-modern-go-reflect2 Fries via Guix-patches via
2023-08-05 11:02   ` [bug#65074] [PATCH v2 12/13] gnu: Add go-github-com-json-iterator-go Fries via Guix-patches via
2023-08-05 11:02   ` [bug#65074] [PATCH v2 13/13] gnu: Add scc Fries via Guix-patches via
2023-08-05 11:53     ` ( via Guix-patches via
2024-04-06 15:50 ` bug#65074: [PATCH 00/13] " Sharlatan Hellseher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmxa3xl5.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=65072@debbugs.gnu.org \
    --cc=65085@debbugs.gnu.org \
    --cc=control@debbugs.gnu.org \
    --cc=fries1234@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.