all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Catonano <catonano@gmail.com>
Cc: 26622-done@debbugs.gnu.org
Subject: bug#26622: [PATCH] Add freexl
Date: Tue, 25 Apr 2017 22:16:18 +0200	[thread overview]
Message-ID: <87vapsqm3x.fsf@elephly.net> (raw)
In-Reply-To: <CAJ98PDzGqs5YKibBEszn_n0QsJEKftT9L6KjirR1+GcBrf22eA@mail.gmail.com>


Catonano <catonano@gmail.com> writes:

> Another xls files reading library.
>
> The home page of Freexl says
>
> FreeXL is licensed under the MPL tri-license terms; you are free to choose
> the best-fit license between:
>
> the MPL 1.1
> the GPL v2.0 or any subsequent version
> the LGPL v2.1 or any subsequent version
>
> I'm not sure what this means for Guix

This means that we write something like this:

    ;; Any of these licenses may be chosen.
    (license (list license:mpl1.1
                   license:gpl2+
                   license:lgpl2.1+))

> Subject: [PATCH 1/1] gnu: Add freexl
>
> * gnu/packages/xml.scm (freexl): New variable.
> ---
>  gnu/packages/xml.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
> index 7460b5d85..02ae00514 100644
> --- a/gnu/packages/xml.scm
> +++ b/gnu/packages/xml.scm
> @@ -1122,3 +1122,23 @@ files.  It is designed to be fast and to handle large input files.")
>       "libxls is a C library which can read Excel (xls) files since Excel 97 (the BIFF8 format).
>  libxls cannot write Excel files.")
>      (license license:bsd-2)))
> +
> +(define-public freexl
> +  (package
> +    (name "freexl")
> +    (version "1.0.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://www.gaia-gis.it/gaia-sins/"
> +                                  name  "-"
> +                                  version ".tar.gz"))

I’d join these two lines.

> +              (sha256
> +               (base32
> +                "17a0yrjb0gln7819j0vp7y25imhvwpil2b0rm44mwgzml0a4i6mk"))))
> +    (build-system gnu-build-system)
> +    (home-page "https://www.gaia-gis.it/fossil/freexl/index")
> +    (synopsis "Read Excel files")
> +    (description
> +     "FreeXL is an open source library to extract valid data
> +from within an Excel (.xls) spreadsheet.")

Please don’t use the term “open source”; besides, all software in Guix
is free software anyway.  Just “FreeXL is a C library to extract …” is
sufficient.

Pushed with these changes to master with commit 623fb4d16.

Thanks!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

  parent reply	other threads:[~2017-04-25 20:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-23 16:36 bug#26622: [PATCH] Add freexl Catonano
2017-04-23 20:32 ` Kei Kebreau
2017-04-23 20:52   ` Catonano
2017-04-24 14:30   ` Marius Bakke
2017-04-25 20:16 ` Ricardo Wurmus [this message]
2017-04-25 20:33   ` Catonano
2017-04-25 20:41     ` Catonano
2017-04-26  6:45       ` Ricardo Wurmus
2017-04-26  7:52         ` Catonano
2017-04-27 10:54           ` Ricardo Wurmus
2017-04-28 16:40             ` Catonano
2017-04-29 17:58               ` Catonano
2017-04-29 18:02                 ` Catonano
2017-05-08  0:24                   ` Leo Famulari
2017-05-08  4:04                     ` Catonano
2017-05-08 17:58                       ` Leo Famulari
2017-05-09 16:46                         ` Catonano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vapsqm3x.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=26622-done@debbugs.gnu.org \
    --cc=catonano@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.