all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Oleg Pykhalov <go.wigust@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 30353@debbugs.gnu.org, 30353-done@debbugs.gnu.org
Subject: [bug#30353] [PATCH] gnu: Add colormake.
Date: Fri, 09 Feb 2018 23:50:01 +0300	[thread overview]
Message-ID: <87vaf53n2e.fsf@gmail.com> (raw)
In-Reply-To: <87d11e4glv.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 09 Feb 2018 11:11:56 +0100")

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Hello Ludovic,

Thank you for review.

ludo@gnu.org (Ludovic Courtès) writes:

  >> +    (synopsis "Simple wrapper around make to make it's output more readable")
  > Rather: “Wrapper around @command{make} to produce colored output”.

  >> +    (description "…")
  > Likewise.

  > Rather than create a new file, perhaps put it in code.scm?

OK.

  > OK with these changes, thank you!

OK, I pushed as dc993847f1a2eed3c0e2b573ee7ad1974ffc3bd0 but I forgot
about description of the commit (is the same as the patch before).  :-\

Apologies.


I'll close the bug report.

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      reply	other threads:[~2018-02-09 20:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05  6:30 [bug#30353] [PATCH] gnu: Add colormake Oleg Pykhalov
2018-02-09 10:11 ` Ludovic Courtès
2018-02-09 20:50   ` Oleg Pykhalov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vaf53n2e.fsf@gmail.com \
    --to=go.wigust@gmail.com \
    --cc=30353-done@debbugs.gnu.org \
    --cc=30353@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.