From: Marius Bakke <mbakke@fastmail.com>
To: Christopher Baines <mail@cbaines.net>, 32153@debbugs.gnu.org
Subject: [bug#32153] [PATCH 0/2]: ruby-build-system: Error or return #t from all phases.
Date: Sun, 15 Jul 2018 01:18:06 +0200 [thread overview]
Message-ID: <87va9h5rv5.fsf@fastmail.com> (raw)
In-Reply-To: <87wotydqm0.fsf@cbaines.net>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
Christopher Baines <mail@cbaines.net> writes:
> I'm trying to continue along with the Rails packaging (#30689), but I
> noticed that currently if the tests fail for packages using the ruby
> build system, then the package build doesn't fail.
>
> These patches should get most of the packages using the ruby build
> system to raise exceptions when there are errors, and return #t
> otherwise.
>
> I'm hopeful that this can be merged directly in to master, I build 180
> packages in not that much time at all to test this change [1].
>
> 1: ./pre-inst-env guix package -s ruby- | recsel -P name | xargs ./pre-inst-env guix build
Thank you for fixing it! Since this only affects gems, not ruby itself
(which has ~900 dependencies), I think it can go on 'master' too[1].
[1] guix refresh -l $(guix package -s ^ruby- | recsel -P name)
By the way, Ruby 2.5 is out. Are you willing to try upgrading it for
'staging'? :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-07-14 23:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-14 11:05 [bug#32153] [PATCH 0/2]: ruby-build-system: Error or return #t from all phases Christopher Baines
2018-07-14 11:10 ` [bug#32153] [PATCH 1/2] " Christopher Baines
2018-07-14 11:10 ` [bug#32153] [PATCH 2/2] gnu: ruby-options: Return #t from set-LIB phase Christopher Baines
2018-07-14 23:11 ` [bug#32153] [PATCH 1/2] ruby-build-system: Error or return #t from all phases Marius Bakke
2018-07-15 21:27 ` bug#32153: " Christopher Baines
2018-07-14 23:18 ` Marius Bakke [this message]
2018-07-15 8:23 ` [bug#32153] [PATCH 0/2]: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va9h5rv5.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=32153@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.