From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 24450@debbugs.gnu.org
Subject: bug#24450: [PATCHv2] Re: pypi importer outputs strange character series in optional dependency case.
Date: Tue, 11 Jun 2019 13:56:46 +0200 [thread overview]
Message-ID: <87v9xc9vy9.fsf@mdc-berlin.de> (raw)
In-Reply-To: <874l4x550r.fsf@gmail.com>
Hi Maxim,
>>> + (call-with-input-file metadata
>>> + (lambda (port)
>>> + (let loop ((requirements '()))
>>> + (let ((line (read-line port)))
>>> + ;; Stop at the first 'Provides-Extra' section: the non-optional
>>> + ;; requirements appear before the optional ones.
>>> + (if (eof-object? line)
>>> + (reverse (delete-duplicates requirements))
>>> + (cond
>>> + ((and (requires-dist-header? line) (not (extra? line)))
>>> + (loop (cons (specification->requirement-name
>>> + (requires-dist-value line))
>>> + requirements)))
>>> + (else
>>> + (loop requirements)))))))))
>>> +
>>
>> As before you can simplify the nested let and merge “if” and "cond“.
>
> Oh, I get it now, I think:
>
> --8<---------------cut here---------------start------------->8---
>
> (call-with-input-file metadata
> (lambda (port)
> (let loop ((requirements '()))
> - (let ((line (read-line port)))
> - ;; Stop at the first 'Provides-Extra' section: the non-optional
> - ;; requirements appear before the optional ones.
> - (if (eof-object? line)
> - (reverse (delete-duplicates requirements))
> - (cond
> - ((and (requires-dist-header? line) (not (extra? line)))
> - (loop (cons (specification->requirement-name
> - (requires-dist-value line))
> - requirements)))
> - (else
> - (loop requirements)))))))))
> + (match (read-line port)
> + (line
> + ;; Stop at the first 'Provides-Extra' section: the non-optional
> + ;; requirements appear before the optional ones.
> + (cond
> + ((eof-object? line)
> + (reverse (delete-duplicates requirements)))
> + ((and (requires-dist-header? line) (not (extra? line)))
> + (loop (cons (specification->requirement-name
> + (requires-dist-value line))
> + requirements)))
> + (else
> + (loop requirements)))))))))
>
> (define (guess-requirements source-url wheel-url archive)
> "Given SOURCE-URL, WHEEL-URL and a ARCHIVE of the package, return a list
> --8<---------------cut here---------------end--------------->8---
Not quite. Your ‘match’ expression here doesn’t do anything that a
‘let’ wouldn’t have done. It really just binds the return value of
(read-line port) to ‘line’; that’s the same as (let ((line (read-line
port))) …).
I gave a match example using predicate matchers in a previous reply. In
any case, using ‘cond’ inside of a let would be just fine. If you
wanted to go with ‘match’, though, you’d replace the ‘cond’.
--
Ricardo
next prev parent reply other threads:[~2019-06-11 11:57 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 20:00 bug#24450: pypi importer outputs strange character series in optional dependency case ng0
2019-03-29 4:24 ` Maxim Cournoyer
2019-06-16 17:02 ` ng0
2019-06-26 4:12 ` Maxim Cournoyer
2019-03-29 4:34 ` bug#24450: [PATCH] " Maxim Cournoyer
2019-03-30 2:12 ` bug#24450: [PATCHv2] " T460s laptop
2019-03-31 14:40 ` bug#24450: [PATCH] " Maxim Cournoyer
2019-04-01 15:28 ` bug#24450: [PATCHv2] " Ludovic Courtès
2019-05-15 11:06 ` Ricardo Wurmus
2019-05-20 4:05 ` bug#24450: [PATCHv2] " Maxim Cournoyer
2019-05-20 15:05 ` Ludovic Courtès
2019-05-22 1:13 ` Maxim Cournoyer
2019-05-27 14:48 ` Ricardo Wurmus
2019-06-10 2:10 ` Maxim Cournoyer
2019-05-27 15:11 ` Ricardo Wurmus
2019-06-10 3:30 ` Maxim Cournoyer
2019-06-10 9:23 ` Ricardo Wurmus
2019-06-16 14:11 ` Maxim Cournoyer
2019-06-17 1:41 ` Ricardo Wurmus
2019-05-27 15:54 ` Ricardo Wurmus
2019-06-10 8:32 ` Maxim Cournoyer
2019-06-10 9:12 ` Ricardo Wurmus
2019-06-16 6:05 ` Maxim Cournoyer
2019-05-27 15:58 ` Ricardo Wurmus
2019-05-28 10:23 ` Ricardo Wurmus
2019-06-10 13:30 ` Maxim Cournoyer
2019-06-10 20:13 ` Ricardo Wurmus
2019-05-28 11:04 ` Ricardo Wurmus
2019-06-11 0:39 ` Maxim Cournoyer
2019-06-11 11:56 ` Ricardo Wurmus [this message]
2019-05-28 13:21 ` Ricardo Wurmus
2019-05-28 14:48 ` Ricardo Wurmus
2019-06-16 5:10 ` Maxim Cournoyer
2019-05-28 14:53 ` Ricardo Wurmus
2019-05-30 2:24 ` Maxim Cournoyer
2019-06-16 5:53 ` Maxim Cournoyer
2019-06-12 3:00 ` Maxim Cournoyer
2019-06-12 6:39 ` Ricardo Wurmus
2019-06-16 14:29 ` Maxim Cournoyer
2019-06-16 14:36 ` bug#24450: [PATCHv3] " Maxim Cournoyer
2019-07-02 1:54 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9xc9vy9.fsf@mdc-berlin.de \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=24450@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.