From: Xinglu Chen <public@yoctocell.xyz>
To: Thorsten Wilms <t_w_@freenet.de>, 49028@debbugs.gnu.org
Subject: [bug#49028] [PATCH] gnu: Add mda-lv2
Date: Tue, 22 Jun 2021 09:44:06 +0200 [thread overview]
Message-ID: <87v966s5rt.fsf@yoctocell.xyz> (raw)
In-Reply-To: <20210620162612.7f6f58f837925c8abfd2d840@freenet.de>
[-- Attachment #1: Type: text/plain, Size: 2454 bytes --]
On Sun, Jun 20 2021, Thorsten Wilms wrote:
> I fixed the description and license. I think there’s no need to change
> away from the tarball, as it’s actually an official release on the code
> author’s domain.
Fair enough.
> Thanks, Xinglu Chen!
You are welcome!
Note that things that shouldn’t be part of the commit message should be
put below the ‘---’ line. The subject should also contain “[PATCH v2]”
to reflect that this is the second version of the patch, you can pass
the ‘--reroll-count=2’ to ‘git send-email’.
Also, I am not able to apply the patch, ‘git am’ reports:
Applying: gnu: Add mda-lv2
error: corrupt patch at line 12
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 gnu: Add mda-lv2
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Your previous patch did apply cleanly, did you do anything differently?
> +(define-public mda-lv2
> + (package
> + (name "mda-lv2")
> + (version "1.2.6")
> + (source
> + (origin
> + (method url-fetch)
> + (uri
> + ;; Tarball from gitlab lacks waflib directory content, so take
> it from
> + ;; drobilla.net.
This comment isn’t accurate anymore, so there is probably no need for
it.
> + (string-append "http://download.drobilla.net/mda-lv2-"
> + version ".tar.bz2"))
> + (sha256
> + (base32
> "1nspk2j11l65m5r9z5isw8j749vh9a89wgx8mkrrq15f4iq12rnd"))))
> + (build-system waf-build-system)
> + (arguments
> + `(#:tests? #f ; There are no tests.
> + #:configure-flags
> + (list (string-append "--prefix="
> + (assoc-ref %outputs "out")))))
> + (inputs
> + `(("lv2" ,lv2)))
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (native-search-paths
> + (list (search-path-specification
> + (variable "LV2_PATH")
> + (files '("lib/lv2")))))
> + (home-page "https://drobilla.net/software/mda-lv2")
> + (synopsis "Audio plug-in pack for LV2")
> + (description
> + MDA-LV2 is an LV2 port of the MDA plugins. It includes effects and
> +a few instrument plugins.
The description should be put inside double quotes :)
Could you send a v3?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-06-22 7:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 19:32 [bug#49028] [PATCH] gnu: Add mda-lv2 Thorsten Wilms
2021-06-18 14:36 ` Xinglu Chen
2021-06-20 14:26 ` Thorsten Wilms
2021-06-22 7:44 ` Xinglu Chen [this message]
2021-06-22 11:00 ` [bug#49028] [PATCH v3] Add mda-lv2. * gnu/packages/audio.scm (mda-lv2): New variable Thorsten Wilms
2021-06-23 8:46 ` Xinglu Chen
2021-06-28 14:49 ` bug#49028: " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v966s5rt.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=49028@debbugs.gnu.org \
--cc=t_w_@freenet.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.