[bug#56111] [PATCH] gnu: playerctl: update to 2.4.1.

[Christopher Baines <mail@cbaines.net>]

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]


Jose G Perez Taveras <josegpt27@gmail.com> writes:

> Hello,
>
> Here is an update to playerctl to 2.4.1 and fixed dependencies.
> It uses `dbus-launch' to start a new daemon.
>
> This is my first time sending a patch, I would be very happy if you
> could point me out to anything I should know.

Hi Jose,

Thanks for the patch.

> +    (propagated-inputs (list dbus))

The addition of dbus as a propagated input was the only thing that stood
out to me.

If playerctl does call out to dbus-launch, then patching the source to
refer to the specific /gnu/store/...-dbus/.../dbus-launch binary would
be the nicest approach, since that would avoid propagating dbus.

Is it necessary to propagate the dbus package, and if so, what doesn't
work if you don't?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]