all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Oleg Pykhalov <go.wigust@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 28832@debbugs.gnu.org, 28832-done@debbugs.gnu.org,
	Alex Kost <alezost@gmail.com>
Subject: bug#28832: [PATCH 1/3] gnu: Add emacs-json-reformat.
Date: Mon, 15 Jan 2018 15:01:01 +0300	[thread overview]
Message-ID: <87tvvntjpe.fsf@gmail.com> (raw)
In-Reply-To: <87po6gm5l6.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 11 Jan 2018 22:46:29 +0100")

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]

Hello Ludovic,

ludo@gnu.org (Ludovic Courtès) writes:

[...]

>>> From d589de21acb02d0fba7aee3b48e5f42d7bd8957e Mon Sep 17 00:00:00 2001
>>> From: Oleg Pykhalov <go.wigust@gmail.com>
>>> Date: Tue, 12 Dec 2017 01:41:08 +0300
>>> Subject: [PATCH] gnu: Add emacs-json-reformat.
>>>
>>> * gnu/packages/patches/emacs-json-reformat-fix-tests.patch: New file.
>>> * gnu/local.mk (dist_patch_DATA): Add this.
>>> * gnu/packages/emacs.scm (emacs-json-reformat): New variable.
>>
>> [...]
>>
>>> diff --git a/gnu/packages/patches/emacs-json-reformat-fix-tests.patch b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch
>>> new file mode 100644
>>> index 000000000..23a239582
>>> --- /dev/null
>>> +++ b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch
>>> @@ -0,0 +1,28 @@
>>> +Copyright © 2017 Oleg Pykhalov <go.wigust@gmail.com>
>>> +
>>> +This patch fixes tests for Emacs 25.
>>
>> Please mention <https://github.com/gongo/json-reformat/issues/33> here.
>>
>> OK with these changes!
>
> We went on discussing other things and forgot about the patch.  :-)
> Could you commit it with these changes, Oleg?

I thought we suspend this until automation of "-L" flags.
Seems like a similar discussion[1] gets stuck too.
Pushed as b0912e9fdbffab15d9a754b2922778cfbd1fac2a

Also pushed emacs-json-mode as dd72837dff128dbb1258826fe39467d1ef000ac1

I'll close current bug report.

Footnotes: 
[1]  https://lists.nongnu.org/archive/html/guix-patches/2017-12/msg00640.html

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2018-01-15 12:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-14  9:51 [bug#28832] [PATCH 0/3] gnu: Add emacs-json-mode Oleg Pykhalov
2017-10-14 10:29 ` [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat Oleg Pykhalov
2017-10-14 10:29   ` [bug#28832] [PATCH 2/3] gnu: Add emacs-json-snatcher Oleg Pykhalov
2017-10-20 12:41     ` Ludovic Courtès
2017-10-14 10:29   ` [bug#28832] [PATCH 3/3] gnu: Add emacs-json-mode Oleg Pykhalov
2017-10-20 12:34   ` [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat Ludovic Courtès
2017-12-01 10:23     ` Ludovic Courtès
2017-12-11 23:12       ` Oleg Pykhalov
2017-12-12  9:17         ` Ludovic Courtès
2017-12-12 17:23           ` Alex Kost
2017-12-13  4:55             ` Oleg Pykhalov
2017-12-15 20:35               ` Alex Kost
2017-12-15  9:36             ` Oleg Pykhalov
2017-12-15 14:02               ` Ludovic Courtès
2017-12-19 10:46                 ` Oleg Pykhalov
2017-12-19 20:57                   ` Alex Kost
2017-12-20  3:26                     ` Oleg Pykhalov
2017-12-20 22:10                       ` Alex Kost
2017-12-21  4:48                         ` Oleg Pykhalov
2017-12-22 20:20                           ` Alex Kost
2017-12-15 20:35               ` Alex Kost
2017-12-19 11:07                 ` Oleg Pykhalov
2018-01-11 21:46           ` Ludovic Courtès
2018-01-15 12:01             ` Oleg Pykhalov [this message]
2018-01-15 13:33               ` Ludovic Courtès
2018-01-16 17:32                 ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvvntjpe.fsf@gmail.com \
    --to=go.wigust@gmail.com \
    --cc=28832-done@debbugs.gnu.org \
    --cc=28832@debbugs.gnu.org \
    --cc=alezost@gmail.com \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.