From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 35783@debbugs.gnu.org
Subject: bug#35783: Guile-Parted crashes the installer on i686-linux
Date: Mon, 20 May 2019 10:17:29 +0200 [thread overview]
Message-ID: <87tvdpwndy.fsf@gnu.org> (raw)
In-Reply-To: <87v9y6cyjp.fsf@gmail.com> (Mathieu Othacehe's message of "Sun, 19 May 2019 16:24:26 +0200")
Hi Mathieu,
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
>> Longer-term it would be good to audit Guile-Parted: it probably
>> shouldn’t be possible for Guile-Parted to refer to “defunct” Parted
>> objects.
>
> Yup, with hindsight I realize that keeping Guile-Parted so low-level was
> a mistake. With a few more abstractions (gnu installer parted) could be
> less complicated.
I don’t know; as a rule of thumb, I think it’s good to make bindings a
direct mapping to the underlying library, and to build abstractions on
top of that.
That said, my point was more that it shouldn’t be possible to get a
null-pointer exception or a SIGSEGV when using Guile-Parted, even if you
make a mistake. In this case, it seems that the underlying C object had
been reclaimed somehow; the bindings should protect against that.
Thoughts?
Ludo’.
next prev parent reply other threads:[~2019-05-20 8:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 19:46 bug#35783: Guile-Parted crashes the installer on i686-linux Ludovic Courtès
2019-05-17 20:03 ` Jonathan Brielmaier
2019-05-17 21:22 ` Ludovic Courtès
2019-05-18 9:30 ` Mathieu Othacehe
2019-05-18 10:25 ` Mathieu Othacehe
2019-05-18 11:50 ` Ludovic Courtès
2019-05-19 14:24 ` Mathieu Othacehe
2019-05-20 8:17 ` Ludovic Courtès [this message]
2019-05-18 13:44 ` Ludovic Courtès
2019-05-19 10:09 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvdpwndy.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35783@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.