all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Thiago Jung Bauermann <bauermann@kolabnow.com>
Cc: 52411-done@debbugs.gnu.org
Subject: bug#52411: [core-updates-frozen] kmod-29 build fails, cross-compiled for i586-pc-gnu
Date: Mon, 17 Jan 2022 12:13:24 -0500	[thread overview]
Message-ID: <87tue2i8uj.fsf@gmail.com> (raw)
In-Reply-To: <2150305.bgRPiZMkaZ@popigai> (Thiago Jung Bauermann's message of "Sat, 18 Dec 2021 01:42:53 -0300")

Hello,

Thiago Jung Bauermann <bauermann@kolabnow.com> writes:

> Hello,
>
> Em sábado, 18 de dezembro de 2021, às 01:11:48 -03, Maxim Cournoyer 
> escreveu:
>> > I think I might have found the issue. The following commit made the
>> > existence/absence 'kmod' input of pciutils depend on %current-
>> > system/%current-target-system:
>> > 
>> > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=22ee7209797c023b9
>> > 5e22ced156df62cbff90184
>> > 
>> > but it forgot to keep in mind that nix systems != triplets.
>> > Instead of %current-target-system, the 'current-target-nix-system'
>> > from ‘https://issues.guix.gnu.org/49672#3’ needs to be used
>> > (or the hurd-target? procedure).
>> 
>> Looking more closely, I don't see an issue with the current conditional
>> seleciting kmod?  nix systems != triplets, but in this case, the
>> conditional is seldom dealing with nix systems, it seems.  Am I missing
>> something?
>> 
>> *** time passes ... reads sources ***
>> 
>> Ah!  per (guix utils), it seems like %current-system is a nix system,
>> while %current-target-system is a GNU triplet.  Confusing!
>
> Guix’s usage of GNU triplets in some places and nix systems in others is a 
> footgun. IMHO we should choose one format and use it everywhere we can, 
> converting to the other if necessary...

Eh, indeed!  I see Maxime has written neat helpers that should mitigate
it to some extent (in guix build utils).  Thank you!

The bug at hand should now be fixed in master.

Closing.

Thanks!

Maxim




      reply	other threads:[~2022-01-17 17:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 12:55 bug#52411: [core-updates-frozen] kmod-29 build fails, cross-compiled for i586-pc-gnu Maxim Cournoyer
2021-12-10 17:48 ` Maxime Devos
2021-12-10 17:55   ` Maxime Devos
2021-12-16 19:02     ` Maxim Cournoyer
2021-12-18  4:11     ` Maxim Cournoyer
2021-12-18  4:42       ` Thiago Jung Bauermann via Bug reports for GNU Guix
2022-01-17 17:13         ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tue2i8uj.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=52411-done@debbugs.gnu.org \
    --cc=bauermann@kolabnow.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.