From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Zhu Zihao <all_but_last@163.com>
Cc: 55517@debbugs.gnu.org
Subject: [bug#55517] [PATCH]: gnu: emacs-magit: Drop the libgit backend.
Date: Sat, 21 May 2022 20:46:13 -0400 [thread overview]
Message-ID: <87tu9i9yy2.fsf@gmail.com> (raw)
In-Reply-To: <865ylzy1pr.fsf@163.com> (Zhu Zihao's message of "Sat, 21 May 2022 11:45:46 +0800")
Hello,
Zhu Zihao <all_but_last@163.com> writes:
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> Hi Zhu,
>>
>> Zhu Zihao <all_but_last@163.com> writes:
>>
>>> Fix the typo in commit message
>>>
>>>>From 8a2de5764a67bea1cbf789c8d6ce0ab0878ec40b Mon Sep 17 00:00:00 2001
>>> From: Zhu Zihao <all_but_last@163.com>
>>> Date: Thu, 19 May 2022 13:01:46 +0800
>>> Subject: [PATCH] gnu: emacs-magit: Drop the libgit backend.
>>>
>>> Drop the libgit backend for following reasons:
>>>
>>> 1. The libgit backend of Magitis very incomplete. There's almost no benefits,
>>> but extra maintenance efforts.
>>
>> Could you elaborate about "almost no benefits"? Even if it's a small
>> benefit, if it makes it faster, I'd still keep it since Magit is at
>> times excruciatingly slow.
>
> It's slow? AFAIK magit user always complain that magit on Windows system
> is slow. The process creation on *nix is much cheaper than Windows, so
> Magit is not slow on *nix.
I've never used it on Windows, but yes, when working with hundred of
commits it's quite slow; just refreshing the status buffer takes ages.
> I've elaborated the reason in
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55427.
>
> The libgit backend of Magit is almost nothing, only one function is
> implemented. `magit-bare-repo-p` will be used in magit-toplevel which is
> called frequently in the magit source code. But this function is cached.
Thanks for that; I've looked at magit-libgit.el and it indeed doesn't
appear to provide much of anything yet. I guess we could drop the
dependency for now and revisit it in the future if/when development
picks up again on the magit/libgit integration.
Thanks,
Maxim
prev parent reply other threads:[~2022-05-22 0:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 5:08 [bug#55517] [PATCH]: gnu: emacs-magit: Drop the libgit backend Zhu Zihao
[not found] ` <handler.55517.B.165293698432676.ack@debbugs.gnu.org>
2022-05-19 5:13 ` [bug#55517] Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.) Zhu Zihao
2022-05-19 6:01 ` Liliana Marie Prikler
2022-05-20 3:52 ` Zhu Zihao
2022-05-20 6:04 ` Liliana Marie Prikler
2022-05-22 9:46 ` Zhu Zihao
2022-05-23 6:46 ` Liliana Marie Prikler
2022-05-28 2:11 ` Zhu Zihao
2022-05-28 6:56 ` bug#55517: " Liliana Marie Prikler
2022-05-21 2:13 ` [bug#55517] [PATCH]: gnu: emacs-magit: Drop the libgit backend Maxim Cournoyer
2022-05-21 3:45 ` Zhu Zihao
2022-05-22 0:46 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu9i9yy2.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=55517@debbugs.gnu.org \
--cc=all_but_last@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.