From: "Ludovic Courtès" <ludo@gnu.org>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: 55316-done@debbugs.gnu.org
Subject: bug#55316: [PATCH] scripts: package: Transform before creating manifest entries.
Date: Mon, 23 May 2022 15:15:41 +0200 [thread overview]
Message-ID: <87tu9g75ky.fsf_-_@gnu.org> (raw)
In-Reply-To: <20220509145410.11678-1-dev@jpoiret.xyz> (Josselin Poiret's message of "Mon, 9 May 2022 16:54:10 +0200")
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
Hi Josselin,
Josselin Poiret <dev@jpoiret.xyz> skribis:
> * guix/scripts/package.scm (options->installable): Add TRANSFORM
> argument, to be able to directly transform the new packages before
> creating their manifest entries.
> (process-actions): Remove transform-entry, and step3, transforming
> directly in step2.
> * tests/guix-package.sh: Add test.
Finally applied with the cosmetic change below, thank you!
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 610 bytes --]
diff --git a/tests/guix-package.sh b/tests/guix-package.sh
index c2f5e39de0..dedba2fd74 100644
--- a/tests/guix-package.sh
+++ b/tests/guix-package.sh
@@ -212,8 +212,8 @@ test ! -f "$profile/bin/sed"
rm "$profile" "$profile"-[0-9]-link
# Make sure transformations apply to propagated inputs and don't lead to
-# conflicts when installing them alongside, see bug
-# <https://lists.gnu.org/archive/html/guix-patches/2022-05/msg00277.html>
+# conflicts when installing them alongside, see
+# <https://issues.guix.gnu.org/55316>.
mkdir "$module_dir"
cat > "$module_dir/test.scm" <<EOF
(define-module (test)
prev parent reply other threads:[~2022-05-23 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 14:16 [bug#55316] [PATCH] scripts: package: Transform before creating manifest entries Josselin Poiret via Guix-patches via
2022-05-09 9:51 ` Ludovic Courtès
2022-05-09 14:54 ` [bug#55316] [PATCH v2] " Josselin Poiret via Guix-patches via
2022-05-23 13:15 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu9g75ky.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=55316-done@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.