all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Raghav Gururajan <rg@raghavgururajan.name>,
	56382@debbugs.gnu.org, Morgan.J.Smith@outlook.com
Subject: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Date: Fri, 15 Jul 2022 21:38:08 -0400	[thread overview]
Message-ID: <87tu7hsupr.fsf@gmail.com> (raw)
In-Reply-To: <877d4e8r79.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 15 Jul 2022 15:02:02 +0200")

Hi Ludovic,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> "Raghav Gururajan" <rg@raghavgururajan.name> skribis:
>
>>> Does simply adding ‘hicolor-icon-theme’ to ‘inputs’ fix the issue?
>>
>> Most gtk-based apps expect hicolor-icon-theme and adwaita-icon-theme to be in the profile. Adding these in either system or user profile would prevent this error from occurring.
>
> Right, so the proposed patch (adding ‘hicolor-icon-theme’ to ‘inputs’,
> not ‘propagated-inputs’) shouldn’t make any difference I guess?

I think it works as inputs because of our wrappers (perhaps
XDG_DATA_DIRS)?  But it's kind at odds with our policy which is to let
users manage icons themselves.

Probably because of #20255 that wouldn't help currently (system and user
profiles are not merged), but if we fixed that bug we could make the
situation better by adding 'hicolor-icon-theme' to the default packages
of our desktop system templates.

Thanks,

Maxim




  reply	other threads:[~2022-07-16  1:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04 13:43 [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup Morgan.J.Smith
2022-07-12 22:15 ` Ludovic Courtès
2022-07-13  8:54 ` Raghav Gururajan via Guix-patches via
2022-07-13 16:06   ` Raghav Gururajan via Guix-patches via
2022-07-15 13:02   ` Ludovic Courtès
2022-07-16  1:38     ` Maxim Cournoyer [this message]
2022-07-18  9:29       ` Ludovic Courtès
2022-07-18 11:21         ` bug#20255: " Maxim Cournoyer
2022-07-18 13:33         ` [bug#56382] " bokr
2022-07-19  8:29           ` Ludovic Courtès
2022-07-18 15:19       ` Raghav Gururajan via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu7hsupr.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=56382@debbugs.gnu.org \
    --cc=Morgan.J.Smith@outlook.com \
    --cc=ludo@gnu.org \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.