all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Nicolas Graves <ngraves@ngraves.fr>
Cc: 57056@debbugs.gnu.org
Subject: [bug#57056] [PATCH] Update python-lsp-server
Date: Fri, 12 Aug 2022 11:03:35 +0200	[thread overview]
Message-ID: <87tu6hzvdk.fsf_-_@gnu.org> (raw)
In-Reply-To: <20220808103608.23372-3-ngraves@ngraves.fr> (Nicolas Graves's message of "Mon, 8 Aug 2022 12:36:08 +0200")


Hello,

> -       (modify-phases %standard-phases
> -         (add-before 'check 'set-HOME
> -           (lambda _ (setenv "HOME" "/tmp")))

You need to document it in the commit message, this way:

[arguments]{set-HOME}: Remove this phase because...
{check}: Do not replace it as test_pyqt_completion is not longer
failing.

or something similar.
>      (propagated-inputs
>       (list python-autopep8
>             python-pydocstyle
>             python-flake8
> -           python-future
>             python-jedi
>             python-lsp-jsonrpc
>             python-pluggy
>             python-pycodestyle
>             python-pyflakes
>             python-rope
> +           python-setuptools
>             python-ujson
>             python-yapf))
>      (native-inputs
>       (list python-coverage
>             python-flaky
>             python-matplotlib
> -           python-mock
>             python-numpy
>             python-pandas
>             python-pylint
>             python-pytest
>             python-pytest-cov
> -           python-versioneer))
> +           python-whatthepatch))

Ditto, with something like

[propagated-inputs]: Remove python-future and add python-setuptools.
[native-inputs]: Remove python-mock, python-versioneer and add
python-whatthepatch.

Could you please send a v2?

Thanks,

Mathieu




  reply	other threads:[~2022-08-12  9:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 10:33 [bug#57056] [PATCH] Update python-lsp-server Nicolas Graves via Guix-patches via
2022-08-08 10:36 ` [bug#57056] [PATCH 1/3] gnu: Add python-whatthepatch Nicolas Graves via Guix-patches via
2022-08-08 10:36   ` [bug#57056] [PATCH 2/3] gnu: python-pluggy: Update to 1.0.0 Nicolas Graves via Guix-patches via
2022-08-12  9:00     ` [bug#57056] [PATCH] Update python-lsp-server Mathieu Othacehe
2022-08-08 10:36   ` [bug#57056] [PATCH 3/3] gnu: python-lsp-server: Update to 1.5.0 Nicolas Graves via Guix-patches via
2022-08-12  9:03     ` Mathieu Othacehe [this message]
2022-08-12 11:00 ` [bug#57056] [PATCH v2 1/3] gnu: Add python-whatthepatch Nicolas Graves via Guix-patches via
2022-08-12 11:00   ` [bug#57056] [PATCH v2 2/3] gnu: python-pluggy: Update to 1.0.0 Nicolas Graves via Guix-patches via
2022-08-12 11:00   ` [bug#57056] [PATCH v2 3/3] gnu: python-lsp-server: Update to 1.5.0 Nicolas Graves via Guix-patches via
2022-08-14 14:14     ` [bug#57056] [PATCH] Update python-lsp-server Mathieu Othacehe
2022-08-14 16:35 ` [bug#57056] [PATCH v3 1/3] gnu: Add python-whatthepatch Nicolas Graves via Guix-patches via
2022-08-14 16:35   ` [bug#57056] [PATCH v3 2/3] gnu: python-pluggy: Update to 1.0.0 Nicolas Graves via Guix-patches via
2022-08-15  8:33     ` [bug#57056] [PATCH] Update python-lsp-server Mathieu Othacehe
2022-08-15  9:54       ` Nicolas Graves via Guix-patches via
2022-08-14 16:36   ` [bug#57056] [PATCH v3 3/3] gnu: python-lsp-server: Update to 1.5.0 Nicolas Graves via Guix-patches via
2022-08-15  7:47     ` bug#57056: [PATCH] Update python-lsp-server Mathieu Othacehe
2022-08-21 10:13 ` [bug#57056] How can I reproduce? Nicolas Graves via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu6hzvdk.fsf_-_@gnu.org \
    --to=othacehe@gnu.org \
    --cc=57056@debbugs.gnu.org \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.