From: Marius Bakke <marius@gnu.org>
To: Josselin Poiret <dev@jpoiret.xyz>, tiantian <typ22@foxmail.com>,
57307-done@debbugs.gnu.org
Subject: bug#57307: guix system reports an error when uuid is used in menu-entry
Date: Sun, 28 Aug 2022 23:46:34 +0200 [thread overview]
Message-ID: <87tu5wdosl.fsf@gnu.org> (raw)
In-Reply-To: <87sflquh1o.fsf@jpoiret.xyz>
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]
Josselin Poiret via Bug reports for GNU Guix <bug-guix@gnu.org> skriver:
> Hi,
>
> tiantian <typ22@foxmail.com> writes:
>
>> I want to add an menu-entry in bootloader-configuration. I use uuid to
>> specify the partition in device field of menu-entry , because my
>> partition has no label. But when I use 'guix system reconfigure', guix
>> system reports an error: "guix system: error: #<<uuid> type: dce bv:
>> #vu8(109 91 19 212 96 146 70 208 139 228 7 61 192 116 19 204)>: invalid
>> G-expression input"
>
> Right, this is an issue with how we translate the menu-entries to sexps
> through `menu-entry->sexp`, which then get embedded into a g-exp via
> `operating-system-boot-parameters-file`! We didn't take into account
> non-string devices there. The following two patches should fix the
> issue and introduce some tests for it.
Pushed in:
3294fa2ba4 tests: Add test for menu-entry roundtrips as sexps.
0811d2cb8d bootloader: Convert device in menu-entry to proper sexp.
Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
prev parent reply other threads:[~2022-08-28 21:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 10:08 bug#57307: guix system reports an error when uuid is used in menu-entry tiantian
2022-08-21 8:39 ` Josselin Poiret via Bug reports for GNU Guix
2022-08-21 8:41 ` bug#57307: [PATCH 1/2] bootloader: Convert device in menu-entry to proper sexp Josselin Poiret via Bug reports for GNU Guix
2022-08-21 8:41 ` bug#57307: [PATCH 2/2] tests: Add test for menu-entry roundtrips as sexps Josselin Poiret via Bug reports for GNU Guix
[not found] ` <016c770e-b5d6-e2ab-b6b3-552b83496cc9@foxmail.com>
[not found] ` <tencent_2CD86BF61F4285B61885E32B31122D6A0C09@qq.com>
2022-08-21 13:03 ` bug#57307: guix system reports an error when uuid is used in menu-entry Josselin Poiret via Bug reports for GNU Guix
2022-08-28 21:46 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu5wdosl.fsf@gnu.org \
--to=marius@gnu.org \
--cc=57307-done@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=typ22@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.